aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zameer Manji" <zma...@apache.org>
Subject Re: Review Request 40656: Remove SessionKey from APIs and implementations.
Date Tue, 24 Nov 2015 21:15:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40656/#review107846
-----------------------------------------------------------

Ship it!


LGTM assuming E2E tests pass and 0.10.0 client can communicate against this scheduler.

- Zameer Manji


On Nov. 24, 2015, 12:29 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40656/
> -----------------------------------------------------------
> 
> (Updated Nov. 24, 2015, 12:29 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
> 
> 
> Bugs: AURORA-814
>     https://issues.apache.org/jira/browse/AURORA-814
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Since our auth* is now transport-level, we don't need it in the app-level messages.
> 
> 
> Diffs
> -----
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift b2628846dfe1d9add0d0edb0e7f2f6ce0121de2b

>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java ccabf55c947393bc04147c8527507e621262e7f3

>   src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java 6d30c25e62061855d8b22d58ad6f33fab7fcc3fb

>   src/main/python/apache/aurora/client/api/scheduler_client.py c973da109103b0b2f2d47e45a353898f0635203c

>   src/test/java/org/apache/aurora/scheduler/http/api/ApiBetaTest.java fb5159db0a0e98d0db2fe506d0497f6b4cc09281

>   src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java 2454959eab3334e10e6bea8b7a600b9e88adb83d

>   src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingInterceptorTest.java
650f21460a3853dc59cec94544125c9c270404b8 
>   src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java
d03cd2ae9798819f3ac9b9a563957393c219bb41 
>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
2bfc2a79aa76a8aed51b428d5d9c2c4e77fca50c 
>   src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 63c20d19a641119e59003b6c31e6b1de3462defb

>   src/test/java/org/apache/aurora/scheduler/thrift/aop/AopModuleTest.java dafcf25cab9c6974fad07cd7ae271983c919f8c4

>   src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java a6769e62d61b2851db055e98ee254f707a91d208

>   src/test/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptorTest.java f0caa8bfa4b48aea7ef448243752ef32c8b0c39a

>   src/test/python/apache/aurora/client/api/test_restarter.py f31d60d7831cb7c6dfdd3978bd4189fe54f856a8

>   src/test/python/apache/aurora/client/api/test_scheduler_client.py d244b3aa14a26ab50e921afaa9c9d7f990d8f1ef

>   src/test/python/apache/aurora/client/api/test_updater.py b7b165351107ecd3d2d73fcbb8139758b969ad00

>   src/test/python/apache/aurora/client/fake_scheduler_proxy.py 183d2d67452d8b57c555b4b9f21f7c2927e323ce

> 
> Diff: https://reviews.apache.org/r/40656/diff/
> 
> 
> Testing
> -------
> 
> I did a quick-and-dirty test between a new client and old scheduler to verify that the
thrift compatibility works as expected and didn't encounter any problems.
> 
> TODO(wfarner): Verify in end-to-end tests.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message