aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aurora ReviewBot" <wfar...@apache.org>
Subject Re: Review Request 40656: Remove SessionKey from APIs and implementations.
Date Tue, 24 Nov 2015 17:27:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40656/#review107806
-----------------------------------------------------------


Master (cd4f7ad) is red with this patch.
  ./build-support/jenkins/build.sh

                     src/test/python/apache/aurora/client/cli/test_cron.py::TestCronNoun::test_schedule_cron_failed_invalid_config
PASSED
                     src/test/python/apache/aurora/client/cli/test_cron.py::TestCronNoun::test_schedule_failed
PASSED
                     src/test/python/apache/aurora/client/cli/test_cron.py::TestCronNoun::test_schedule_failed_non_cron
PASSED
                     src/test/python/apache/aurora/client/cli/test_cron.py::TestCronNoun::test_start_cron
PASSED
                     src/test/python/apache/aurora/client/cli/test_cron.py::TestCronNoun::test_start_cron_open_browser
PASSED
                     src/test/python/apache/aurora/client/cli/test_cron.py::TestCronNoun::test_successful_schedule

17:27:39 00:56         [chroot]PASSED
                     
                      generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/src.test.python.apache.aurora.client.cli.cron.xml

                     =========== 10 passed in 1.38 seconds ============
                     ============== test session starts ===============
                     platform linux2 -- Python 2.7.6 -- py-1.4.30 -- pytest-2.6.4 -- /usr/bin/python2.7
                     plugins: cov, timeout
                     
                     collecting 0 items
                     src.test.python.apache.aurora.client.api.updater                    
           .....   FAILURE
                     src.test.python.apache.aurora.client.cli.config                     
           .....   SUCCESS
                     src.test.python.apache.aurora.client.cli.cron                       
           .....   SUCCESS
                     src.test.python.apache.aurora.client.hooks.non_hooked_api           
           .....   SUCCESS
                     src.test.python.apache.aurora.common.test_http_signaler             
           .....   SUCCESS
                     src.test.python.apache.aurora.executor.common.path_detector         
           .....   SUCCESS
                     src.test.python.apache.aurora.executor.common.task_info             
           .....   SUCCESS
                     src.test.python.apache.thermos.cli.common                           
           .....   SUCCESS
                     src.test.python.apache.thermos.cli.main                             
           .....   SUCCESS
                     src.test.python.apache.thermos.cli.commands.commands                
           .....   SUCCESS
                     src.test.python.apache.thermos.common.test_pathspec                 
           .....   SUCCESS
                     src.test.python.apache.thermos.monitoring.test_disk                 
           .....   SUCCESS
                     collecting 0 items / 1 errors
                     collected 0 items / 1 errors 
                     
                     ===================== ERRORS =====================
                      ERROR collecting src/test/python/apache/aurora/client/api/test_updater.py

                     src/test/python/apache/aurora/client/api/test_updater.py:34: in <module>
                         from gen.apache.aurora.api.ttypes import (
                     E   ImportError: cannot import name SessionKey
                      generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/src.test.python.apache.aurora.client.api.updater.xml

                     ============ 1 error in 0.61 seconds =============
                     
FAILURE


17:27:41 00:58   [complete]
               FAILURE


I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Nov. 24, 2015, 5:19 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40656/
> -----------------------------------------------------------
> 
> (Updated Nov. 24, 2015, 5:19 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
> 
> 
> Bugs: AURORA-814
>     https://issues.apache.org/jira/browse/AURORA-814
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Since our auth* is now transport-level, we don't need it in the app-level messages.
> 
> 
> Diffs
> -----
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift b2628846dfe1d9add0d0edb0e7f2f6ce0121de2b

>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java ccabf55c947393bc04147c8527507e621262e7f3

>   src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java 6d30c25e62061855d8b22d58ad6f33fab7fcc3fb

>   src/main/python/apache/aurora/client/api/scheduler_client.py c973da109103b0b2f2d47e45a353898f0635203c

>   src/test/java/org/apache/aurora/scheduler/http/api/ApiBetaTest.java fb5159db0a0e98d0db2fe506d0497f6b4cc09281

>   src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java 2454959eab3334e10e6bea8b7a600b9e88adb83d

>   src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingInterceptorTest.java
650f21460a3853dc59cec94544125c9c270404b8 
>   src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java
d03cd2ae9798819f3ac9b9a563957393c219bb41 
>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
2bfc2a79aa76a8aed51b428d5d9c2c4e77fca50c 
>   src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 63c20d19a641119e59003b6c31e6b1de3462defb

>   src/test/java/org/apache/aurora/scheduler/thrift/aop/AopModuleTest.java dafcf25cab9c6974fad07cd7ae271983c919f8c4

>   src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java a6769e62d61b2851db055e98ee254f707a91d208

>   src/test/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptorTest.java f0caa8bfa4b48aea7ef448243752ef32c8b0c39a

> 
> Diff: https://reviews.apache.org/r/40656/diff/
> 
> 
> Testing
> -------
> 
> I did a quick-and-dirty test between a new client and old scheduler to verify that the
thrift compatibility works as expected and didn't encounter any problems.
> 
> TODO(wfarner): Verify in end-to-end tests.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message