aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Sirois" <john.sir...@gmail.com>
Subject Re: Review Request 40391: Introduce a utility class to read executor configurations in JSON.
Date Tue, 17 Nov 2015 16:57:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40391/#review106882
-----------------------------------------------------------

Ship it!



src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorSettingsLoader.java
(line 79)
<https://reviews.apache.org/r/40391/#comment165689>

    Isn't Schema.class enough?  No type parameter to capture here.


- John Sirois


On Nov. 17, 2015, 9:28 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40391/
> -----------------------------------------------------------
> 
> (Updated Nov. 17, 2015, 9:28 a.m.)
> 
> 
> Review request for Aurora, John Sirois and Zameer Manji.
> 
> 
> Bugs: AURORA-1376
>     https://issues.apache.org/jira/browse/AURORA-1376
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Another bit-sized chunk towards AURORA-1376.  The follow-up will allow an executor configuration
file to be provided on the scheduler command line.
> 
> 
> Diffs
> -----
> 
>   build.gradle 17dbd2575138880e8ecbbee2b9daf0f1631172c3 
>   src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorSettingsLoader.java
PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/mesos/TestExecutorSettings.java 556a3f80236971f6b6cf443d9d1de9394a3aae2d

>   src/test/java/org/apache/aurora/scheduler/configuration/executor/ExecutorSettingsLoaderTest.java
PRE-CREATION 
>   src/test/resources/org/apache/aurora/scheduler/configuration/executor/test-missing-field.json
PRE-CREATION 
>   src/test/resources/org/apache/aurora/scheduler/configuration/executor/test-thermos-executor.json
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40391/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message