aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Sirois" <john.sir...@gmail.com>
Subject Re: Review Request 40323: Improve the isolation in the thrift build.
Date Mon, 16 Nov 2015 22:23:22 GMT


> On Nov. 16, 2015, 3:18 p.m., Zameer Manji wrote:
> > build-support/thrift/Makefile, line 28
> > <https://reviews.apache.org/r/40323/diff/6/?file=1127537#file1127537line28>
> >
> >     The ticket says this patch was committed in 0.9.2. Would it be more productive
to upgrade to 0.9.2+ before complicating our thrift build?
> >     
> >     Not a blocker to landing this but I think it would be nice if we didn't have
to download a patch for our vendored thrit.
> 
> John Sirois wrote:
>     Sadly 0.9.2 and 0.9.3 are not useable in python, details here: https://issues.apache.org/jira/browse/THRIFT-3388
>     In short, thrift folks accepted a patch they never should have that poisened python
use for any but the vey simplest structs and service methods.

More info on this from the Aurora point of view is here: https://issues.apache.org/jira/browse/AURORA-1083


- John


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40323/#review106749
-----------------------------------------------------------


On Nov. 16, 2015, 1:11 p.m., John Sirois wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40323/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2015, 1:11 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This improves the isolation of the thrift build by building a local
> pinned bison dep. For one, this gets thrift 0.9.1 building on Arch
> Linux, a rolling release that is otherwise too modern in its libs to
> successfully build thrift 0.9.1.
> 
> Additionally, this change knocks out the checksumming TODO and now
> checks all downloaded tarballs meet their expected hashes.  The
> hashes were generated locally after checking the sha1's where
> available.
> 
> 
> Diffs
> -----
> 
>   build-support/thrift/.gitignore ad6155ebe8671514b5bf5751f250b6cd71c858b7 
>   build-support/thrift/Makefile 51f37a959041536004f83a60d038f2116be8c8a9 
> 
> Diff: https://reviews.apache.org/r/40323/diff/
> 
> 
> Testing
> -------
> 
> I can now run `./build-support/jenkins/build.sh` green locally.
> 
> I also got a hold of an OSX 10.10.5 box and was able to run
> `./build-support/jenkins/build.sh` green on it using this change.
> 
> 
> Thanks,
> 
> John Sirois
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message