aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Sirois" <john.sir...@gmail.com>
Subject Re: Review Request 40324: Isolate the `third_party/` repo to `mesos.native`.
Date Mon, 16 Nov 2015 16:48:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40324/
-----------------------------------------------------------

(Updated Nov. 16, 2015, 9:48 a.m.)


Review request for Aurora, Joshua Cohen and Bill Farner.


Changes
-------

Improve documentation of mesos.native gymnastics.

 3rdparty/python/requirements.txt          | 15 +++++++++++++++
 examples/vagrant/provision-dev-cluster.sh |  1 +
 2 files changed, 16 insertions(+)


Bugs: AURORA-1538
    https://issues.apache.org/jira/browse/AURORA-1538


Repository: aurora


Description
-------

This lifts `mesos.interface` and `mesos.native` out of
`requirements.txt`, ties their versions together and isolates the
custom repository needed by `mesos.native` to its `python_requirement`.

 3rdparty/python/BUILD            | 26 ++++++++++++++++++++++++++
 3rdparty/python/requirements.txt |  2 --
 pants.ini                        |  5 -----
 3 files changed, 26 insertions(+), 7 deletions(-)


Diffs (updated)
-----

  3rdparty/python/BUILD 7ef81d13afa0089d7e8a779e71b53e0fc1848466 
  3rdparty/python/requirements.txt 3a78b754ad8e55308554119e279693053951cc6e 
  examples/vagrant/provision-dev-cluster.sh 4474543bac16ac5af0de1f199e36e8b981d52e04 
  pants.ini 319d38e9a7af8055cac5bbce4a6ae0cbb38dc8d0 

Diff: https://reviews.apache.org/r/40324/diff/


Testing
-------

Successfully ran end-to-end with this change using a fresh vagrant
image and clean repo via:
```
vagrant destroy && \
bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
```


Thanks,

John Sirois


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message