aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Sirois" <john.sir...@gmail.com>
Subject Re: Review Request 40299: Restore the third_party python repo, needed for mesos.native egg.
Date Sun, 15 Nov 2015 00:19:20 GMT


> On Nov. 13, 2015, 9:55 a.m., John Sirois wrote:
> > pants.ini, line 33
> > <https://reviews.apache.org/r/40299/diff/1/?file=1125123#file1125123line33>
> >
> >     Seems worth a note this is only used by the vagrant provisioning ... or add
this to `examples/vagrant/aurorabuild.sh`:
> >     
> >     ```
> >     export PANTS_CONFIG_OVERRIDE="['vagrant.ini']"
> >     ```
> >     
> >     Path to the override ini is whatever it needs to be, but it need only contain
the entry you added here.
> 
> John Sirois wrote:
>     Looks like the site doc is stale - option is singular valued and the name is pluralized
- but some doc here: https://pantsbuild.github.io/invoking.html#overlay-ini-files-with-config-overrides
>     But the correct option help is found via `./pants help-advanced`
> 
> Bill Farner wrote:
>     That wouldn't really work, as it's needed any time `src/main/python/apache/aurora/executor:thermos_executor`
is built (more specifically - when `3rdparty/python:mesos.native` is included as a dep.  Seems
like a comment is the only sane path forward, right?
> 
> John Sirois wrote:
>     SGTM.  Looks like more cleanup could happen going forward though since - fwict -
the only way to get that dep right now is:
>     ```
>     examples/vagrant/provision-dev-cluster.sh:      wget -c https://svn.apache.org/repos/asf/aurora/3rdparty/ubuntu/trusty64/python/mesos.native-${MESOS_VERSION}-py2.7-linux-x86_64.egg
>     ```
> 
> John Sirois wrote:
>     Looks relevant: https://issues.apache.org/jira/browse/AURORA-972
> 
> John Sirois wrote:
>     I may follow-up with another approach now that I know to test the vagrant bit oob
from CI.  I think this can be localized to the 3rdparty/python/BUILD.

That other approach is over here: https://reviews.apache.org/r/40324/


- John


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40299/#review106438
-----------------------------------------------------------


On Nov. 13, 2015, 10:24 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40299/
> -----------------------------------------------------------
> 
> (Updated Nov. 13, 2015, 10:24 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and John Sirois.
> 
> 
> Bugs: AURORA-1538
>     https://issues.apache.org/jira/browse/AURORA-1538
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Restore the third_party python repo, needed for mesos.native egg.
> 
> 
> Diffs
> -----
> 
>   pants.ini b12248c4834fa172b80506b3872c75df666b85cf 
> 
> Diff: https://reviews.apache.org/r/40299/diff/
> 
> 
> Testing
> -------
> 
> I can now build the executor in vagrant.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message