aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aurora ReviewBot" <wfar...@apache.org>
Subject Re: Review Request 40320: Organize executor-related code into a package.
Date Sat, 14 Nov 2015 17:13:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40320/#review106546
-----------------------------------------------------------

Ship it!


Master (7b494f4) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Nov. 14, 2015, 5 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40320/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2015, 5 p.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This is pure code shuffle, the interesting bits coming out of `SchedulerMain` and into
`ExecutorModule`.
> 
> Probably should have done this in https://reviews.apache.org/r/40149/, but another follow-up
change made it more obvious that this organization was needed.
> 
> 
> Diffs
> -----
> 
>   config/legacy_untested_classes.txt aac822b6e2c022625432e09ad8d4097790429257 
>   src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java b4ca01b0ae751bdc8fa2d6fb7c667fe3c08ca726

>   src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java 6236a531b2bb1c9ba09840911ec6d4846cdb9393

>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java fb4f0a031d3976cbd225fc050487b4002e64ae0c

>   src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java
PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 52776c9cb70127cb88a40f98e2c7cce192b3b5b1

>   src/main/java/org/apache/aurora/scheduler/mesos/ExecutorConfig.java b6aa2e1567c79156e1ad7270d430a6fcb282822d

>   src/main/java/org/apache/aurora/scheduler/mesos/ExecutorSettings.java b7f30231329fe2cf5bc72d11b1f929f394c21c6b

>   src/main/java/org/apache/aurora/scheduler/mesos/Executors.java 21152f575ed6b0cafe5739df718ef735837b19ac

>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java f1c2059045624ed2486982614f9df14829a00ebc

>   src/main/java/org/apache/aurora/scheduler/mesos/TestExecutorSettings.java ad5927c9d67749a1a83640ee94d76919640a7949

>   src/main/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilter.java b14ab68017b0c66141f6a8bae4b0eacde841a3a2

>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java da7d1e0dfb6aa8ddf452de79db8bd23491822c89

>   src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 50853cfffab832d75f5106742d38a1864d9c6c30

>   src/test/java/org/apache/aurora/scheduler/mesos/TaskExecutors.java a258d06cb12b2962d47dbb74a2af29281e255662

> 
> Diff: https://reviews.apache.org/r/40320/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message