aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joshua Cohen" <jco...@apache.org>
Subject Re: Review Request 40201: Cleanup thermos_executor test pexes.
Date Fri, 13 Nov 2015 15:34:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40201/#review106421
-----------------------------------------------------------

Ship it!


Ship It!

- Joshua Cohen


On Nov. 13, 2015, 3:32 p.m., John Sirois wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40201/
> -----------------------------------------------------------
> 
> (Updated Nov. 13, 2015, 3:32 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Kevin Sweeney, Brian Wickman, and Zameer Manji.
> 
> 
> Bugs: AURORA-547
>     https://issues.apache.org/jira/browse/AURORA-547
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Previously these were built to the standard `dist/` dir, now they are
> dumped to a tmp dir that's cleaned up.
> 
>  src/test/python/apache/aurora/executor/test_thermos_executor.py    | 24 +++++++++++++++++++-----
>  src/test/python/apache/aurora/executor/test_thermos_task_runner.py | 15 ++++++++++-----
>  2 files changed, 29 insertions(+), 10 deletions(-)
> 
> 
> Diffs
> -----
> 
>   src/test/python/apache/aurora/executor/test_thermos_executor.py d24c61162e11bb4afef2902ebb031478fe3ed247

>   src/test/python/apache/aurora/executor/test_thermos_task_runner.py bb998c0b0ac87ba51ec13e490338b00e7f85e8cf

> 
> Diff: https://reviews.apache.org/r/40201/diff/
> 
> 
> Testing
> -------
> 
> Green locally:
> ```
> $ rm -rf dist/ && \
>   ./pants test.pytest --no-fast src/test/python/apache/aurora/executor:
> ```
> 
> And no `dist/` created.
> 
> 
> Thanks,
> 
> John Sirois
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message