aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aurora ReviewBot" <wfar...@apache.org>
Subject Re: Review Request 40220: Modernize the pex venv script.
Date Thu, 12 Nov 2015 08:53:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40220/#review106211
-----------------------------------------------------------

Ship it!


Master (48aedae) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Nov. 12, 2015, 8:35 a.m., John Sirois wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40220/
> -----------------------------------------------------------
> 
> (Updated Nov. 12, 2015, 8:35 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney, Bill Farner, and Brian Wickman.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This converts from grabbing the old Twitter python pex to grabbing
> modern pex to match the version specified in 3rdparty to help keep the
> pex venv up to date with the codebase dependencies.
> 
>  build-support/pex | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> 
> Diffs
> -----
> 
>   build-support/pex 54e31f11f152cada3809ebd7b2cdec1d2ba12ac9 
> 
> Diff: https://reviews.apache.org/r/40220/diff/
> 
> 
> Testing
> -------
> 
> Locally ran this 2x and observed both the proper version (1.1.0) and
> proper use of the cached venv in the second run:
> `git clean -fdx build-support && ./build-support/pex --version`
> 
> 
> Thanks,
> 
> John Sirois
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message