Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B751018A75 for ; Wed, 28 Oct 2015 02:04:06 +0000 (UTC) Received: (qmail 10206 invoked by uid 500); 28 Oct 2015 02:03:57 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 10150 invoked by uid 500); 28 Oct 2015 02:03:57 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 10127 invoked by uid 99); 28 Oct 2015 02:03:56 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 28 Oct 2015 02:03:56 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 49A4527AC97; Wed, 28 Oct 2015 02:03:56 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1056760878697611901==" MIME-Version: 1.0 Subject: Re: Review Request 39629: Remove ChainedPathDetector and root argument from the observer. From: "Aurora ReviewBot" To: "Bill Farner" , "Maxim Khutornenko" Cc: "Aurora ReviewBot" , "Zameer Manji" , "Aurora" Date: Wed, 28 Oct 2015 02:03:56 -0000 Message-ID: <20151028020356.22462.2334@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Aurora ReviewBot" X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/39629/ X-Sender: "Aurora ReviewBot" References: <20151027233801.22461.19108@reviews.apache.org> In-Reply-To: <20151027233801.22461.19108@reviews.apache.org> Reply-To: "Aurora ReviewBot" X-ReviewRequest-Repository: aurora --===============1056760878697611901== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39629/#review104242 ----------------------------------------------------------- Master (c20346c) is red with this patch. ./build-support/jenkins/build.sh :processJmhResources UP-TO-DATE :jmhClasses :checkstyleJmh :jsHint :checkstyleMain :compileTestJavaNote: Some input files use or override a deprecated API. Note: Recompile with -Xlint:deprecation for details. :processTestResources :testClasses :checkstyleTest :findbugsJmh :findbugsMain :findbugsTest :licenseJmh UP-TO-DATE :licenseMain UP-TO-DATE :licenseTest UP-TO-DATE :license UP-TO-DATE :pmdMain :test :jacocoTestReport Coverage report generated: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/jacoco/test/html/index.html :analyzeReport Instruction coverage is 0.8878761574074074, but must be greater than 0.89 Branch coverage is 0.8137074517019319, but must be greater than 0.835 :analyzeReport FAILED FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':analyzeReport'. > Test coverage missing for org/apache/aurora/GuavaUtils$LifecycleShutdownListener * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. BUILD FAILED Total time: 6 mins 22.075 secs I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Oct. 27, 2015, 11:38 p.m., Zameer Manji wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39629/ > ----------------------------------------------------------- > > (Updated Oct. 27, 2015, 11:38 p.m.) > > > Review request for Aurora, Maxim Khutornenko and Bill Farner. > > > Bugs: AURORA-1338 > https://issues.apache.org/jira/browse/AURORA-1338 > > > Repository: aurora > > > Description > ------- > > Remove ChainedPathDetector and root argument from the observer. > > > Diffs > ----- > > NEWS 40fe13985a7f8d69252edac37187f1993a05c47c > examples/vagrant/upstart/aurora-thermos-observer.conf d7d649dc8aaacd98772183fa1429ef8fc84fa20a > src/main/python/apache/aurora/tools/thermos_observer.py 82de0a14b36666de2bf3d1b7282fe7dc9fc185d7 > > Diff: https://reviews.apache.org/r/39629/diff/ > > > Testing > ------- > > e2e tests passed > > > Thanks, > > Zameer Manji > > --===============1056760878697611901==--