Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E507F18895 for ; Thu, 22 Oct 2015 21:35:29 +0000 (UTC) Received: (qmail 25901 invoked by uid 500); 22 Oct 2015 21:35:29 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 25854 invoked by uid 500); 22 Oct 2015 21:35:29 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 25822 invoked by uid 99); 22 Oct 2015 21:35:29 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Oct 2015 21:35:29 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 2A807278E3D; Thu, 22 Oct 2015 21:35:29 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1807001541498526466==" MIME-Version: 1.0 Subject: Re: Review Request 39563: Ignore serverInfo on the client side. From: "Kevin Sweeney" To: "Maxim Khutornenko" , "Zameer Manji" Cc: "Aurora ReviewBot" , "Kevin Sweeney" , "Aurora" Date: Thu, 22 Oct 2015 21:35:29 -0000 Message-ID: <20151022213529.1666.3336@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Kevin Sweeney" X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/39563/ X-Sender: "Kevin Sweeney" References: <20151022174725.5315.5441@reviews.apache.org> In-Reply-To: <20151022174725.5315.5441@reviews.apache.org> Reply-To: "Kevin Sweeney" X-ReviewRequest-Repository: aurora --===============1807001541498526466== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39563/ ----------------------------------------------------------- (Updated Oct. 22, 2015, 2:35 p.m.) Review request for Aurora, Maxim Khutornenko and Zameer Manji. Changes ------- Remove unused import. Bugs: AURORA-1522 https://issues.apache.org/jira/browse/AURORA-1522 Repository: aurora Description ------- Ignore serverInfo on the client side. The design of this check is flawed - the client has already sent an RPC to the scheduler and received a response for it, meaning the request has already been processed and this check only serves to ignore its results. Diffs (updated) ----- src/main/python/apache/aurora/client/api/scheduler_client.py 8e91788d8cb69ef21df6b045cd07f8cb111b95b3 src/test/python/apache/aurora/client/api/test_scheduler_client.py 10e8ebb4a12cc39d296cfde64ed9b01119d0aac3 Diff: https://reviews.apache.org/r/39563/diff/ Testing ------- Thanks, Kevin Sweeney --===============1807001541498526466==--