Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@aurora.apache.org
Content-Type: multipart/alternative;
 boundary="===============5463390507055987125=="
MIME-Version: 1.0
Subject: Re: Review Request 39366: Adding job update diff details into "aurora
 job diff" command.
From: "Joshua Cohen" <jcohen@apache.org>
To: "Joshua Cohen" <jcohen@apache.org>, "Bill Farner" <wfarner@apache.org>
Cc: "Maxim Khutornenko" <maxim@apache.org>,
 "Aurora" <reviews@aurora.apache.org>
Date: Tue, 20 Oct 2015 16:49:10 -0000
Message-ID: <20151020164910.1667.18516@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Joshua Cohen" <noreply@reviews.apache.org>
References: <20151019172350.32263.63461@reviews.apache.org>
In-Reply-To: <20151019172350.32263.63461@reviews.apache.org>
Reply-To: "Joshua Cohen" <jcohen@apache.org>

--===============5463390507055987125==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39366/#review103268
-----------------------------------------------------------

Ship it!


Not a blocker, but do you think the arrows in the output are necessary? They feel like extra noise to me. Maybe replace them with tabs instead?


src/main/python/apache/aurora/client/api/__init__.py (lines 175 - 176)
<https://reviews.apache.org/r/39366/#comment161261>

    This is going to double log, we log once in the call to `_job_update_request` and again right after. I'd remove the log from `_job_update_request`?


- Joshua Cohen


On Oct. 19, 2015, 5:23 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39366/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2015, 5:23 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-1516
>     https://issues.apache.org/jira/browse/AURORA-1516
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> "aurora job diff" now prints update sequence along with diff details when applicable (updated instances).
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/api/__init__.py 4b9c48e84bc203fc7b28d7efd0b2e6b8a6f18302 
>   src/main/python/apache/aurora/client/cli/jobs.py 6d15f1e8558f9df5f00994d20949f19b0de1ad32 
>   src/test/python/apache/aurora/client/api/test_api.py b56e35265b1e32d61a13fe72734cae824737278d 
>   src/test/python/apache/aurora/client/cli/test_diff.py 753a0417caf29249cbc2fca5a9fc41b1ce535c92 
>   src/test/python/apache/aurora/client/cli/util.py b03148b4edaa334620a72bee1937c8c16e19f23e 
> 
> Diff: https://reviews.apache.org/r/39366/diff/
> 
> 
> Testing
> -------
> 
> ./pants test.pytest --no-fast src/test/python::
> 
> Also tested manually in vagrant:
> 
> Upscale and update:
> ```
> $ aurora job diff devcluster/www-data/prod/hello aurora/examples/jobs/hello_world.aurora 
>  INFO] Starting update for: hello
> A job update with this config will:
> ----> add instances: [100-119]
> ----> update instances: [0-9], [21-29], [41-44], [61-99]
> with diff:
> 64c64
> <           "cpu": 2.0, 
> ---
> >           "cpu": 3.0, 
> 75c75
> <   'numCpus': 2.0,
> ---
> >   'numCpus': 3.0,
> ----> update instances: [30-40], [45-60]
> with diff:
> 64c64
> <           "cpu": 4.0, 
> ---
> >           "cpu": 3.0, 
> 75c75
> <   'numCpus': 4.0,
> ---
> >   'numCpus': 3.0,
> ----> not change instances: [10-20]
> ```
> 
> Diff with instance spec:
> ```
> $ aurora job diff devcluster/www-data/prod/hello/0-10 aurora/examples/jobs/hello_world.aurora 
>  INFO] Starting update for: hello
> A job update with this config will:
> ----> remove instances: [10]
> ----> update instances: [0-9]
> with diff:
> 64c64
> <           "cpu": 2.0, 
> ---
> >           "cpu": 3.0, 
> 75c75
> <   'numCpus': 2.0,
> ---
> >   'numCpus': 3.0,
> ----> not change instances: [11-20], [21-29], [30-40], [41-44], [45-60], [61-99]
> ```
> 
> Downscale and update:
> ```
> $ aurora job diff devcluster/www-data/prod/hello aurora/examples/jobs/hello_world.aurora 
>  INFO] Starting update for: hello
> A job update with this config will:
> ----> remove instances: [10-20], [21-29], [30-40], [41-44], [45-60], [61-99]
> ----> update instances: [0-9]
> with diff:
> 64c64
> <           "cpu": 2.0, 
> ---
> >           "cpu": 3.0, 
> 75c75
> <   'numCpus': 2.0,
> ---
> >   'numCpus': 3.0,
> ```
> 
> Update non-existent job:
> ```
> $ aurora job diff devcluster/www-data/prod/hello1 aurora/examples/jobs/hello_world.aurora 
>  INFO] Starting update for: hello1
> A job update with this config will:
> ----> add instances: [0-9]
> ```
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


--===============5463390507055987125==--