Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8371618DB6 for ; Tue, 13 Oct 2015 20:51:59 +0000 (UTC) Received: (qmail 46536 invoked by uid 500); 13 Oct 2015 20:51:59 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 46488 invoked by uid 500); 13 Oct 2015 20:51:59 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 46468 invoked by uid 99); 13 Oct 2015 20:51:59 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Oct 2015 20:51:59 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 8CBDD2772AA; Tue, 13 Oct 2015 20:51:57 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2958603274202062092==" MIME-Version: 1.0 Subject: Re: Review Request 39143: Adding getJobUpdateDiff thrift API. From: "Bill Farner" To: "Bill Farner" , "David McLaughlin" Cc: "Maxim Khutornenko" , "Aurora" Date: Tue, 13 Oct 2015 20:51:57 -0000 Message-ID: <20151013205157.1509.13650@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Bill Farner" X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/39143/ X-Sender: "Bill Farner" References: <20151009224356.16483.58921@reviews.apache.org> In-Reply-To: <20151009224356.16483.58921@reviews.apache.org> Reply-To: "Bill Farner" X-ReviewRequest-Repository: aurora --===============2958603274202062092== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39143/#review102532 ----------------------------------------------------------- Ship it! src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java (line 475) "Diff is not currently supported for cron jobs." - Bill Farner On Oct. 9, 2015, 3:43 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39143/ > ----------------------------------------------------------- > > (Updated Oct. 9, 2015, 3:43 p.m.) > > > Review request for Aurora, David McLaughlin and Bill Farner. > > > Bugs: AURORA-1515 > https://issues.apache.org/jira/browse/AURORA-1515 > > > Repository: aurora > > > Description > ------- > > Adding the API to return update instructions. Design doc: https://docs.google.com/document/d/1Fc_YhhV7fc4D9Xv6gJzpfooxbK4YWZcvzw6Bd3qVTL8 > > > Diffs > ----- > > api/src/main/thrift/org/apache/aurora/gen/api.thrift f56d7bdc5cdbb2fc84254c41328b01c1367c8343 > src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java c09130bcd4deae80e475f531e5bc08dac475f0e8 > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 4efcd2cd81290e919be5cf1de94c5aeb0851c67e > src/main/java/org/apache/aurora/scheduler/updater/JobDiff.java a17337fb2df8e6e2a2905e88ff1f1eeb03e7d406 > src/test/java/org/apache/aurora/scheduler/thrift/Fixtures.java adcc02b3313220c728a9025b9aec787646f71058 > src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java 82e7330a83ff366fab81385608c62d92445f5e16 > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 83f65a73fc2053b138854be13a3b6c7748f80c2b > src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java d25618c19615ee097c1f2c4b6fefc70c565c649c > src/test/java/org/apache/aurora/scheduler/updater/JobDiffTest.java 64d45813d89d5f084aec70cd87aadb01de7f6d41 > > Diff: https://reviews.apache.org/r/39143/diff/ > > > Testing > ------- > > ./gradlew -Pq build > > > Thanks, > > Maxim Khutornenko > > --===============2958603274202062092==--