aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zameer Manji" <zma...@apache.org>
Subject Re: Review Request 39670: Modify ClusterStateImpl to be thread safe.
Date Thu, 29 Oct 2015 20:44:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39670/
-----------------------------------------------------------

(Updated Oct. 29, 2015, 1:44 p.m.)


Review request for Aurora, Maxim Khutornenko and Bill Farner.


Changes
-------

Bill's feedback.


Bugs: AURORA-1510
    https://issues.apache.org/jira/browse/AURORA-1510


Repository: aurora


Description
-------

ClusterStateImpl exposes a synchronized multimap which does not have a thread-safe implementation
of `keySet`. This patch revises the `ClusterState` interface to offer more precise operations
and modifies `ClusterStateImpl` to makes all of these operations thread safe.


Diffs (updated)
-----

  src/main/java/org/apache/aurora/scheduler/preemptor/ClusterStateImpl.java 42e2ca49b3c5de997cb5363e3518512d0f5a725e

  src/test/java/org/apache/aurora/scheduler/preemptor/ClusterStateImplTest.java a1ac922d471013779710e02c0c9ca9f84b506807


Diff: https://reviews.apache.org/r/39670/diff/


Testing
-------

./gradlew build -Pq

If the approach is good, I can update this with benchmark information.


Thanks,

Zameer Manji


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message