aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zameer Manji" <>
Subject Re: Review Request 39670: Modify ClusterStateImpl to be thread safe.
Date Wed, 28 Oct 2015 04:12:04 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Oct. 27, 2015, 9:12 p.m.)

Review request for Aurora, Maxim Khutornenko and Bill Farner.


Revise implementation.

Summary (updated)

Modify ClusterStateImpl to be thread safe.

Bugs: AURORA-1510

Repository: aurora

Description (updated)

ClusterStateImpl exposts a synchronized multimap which does not have a thread-safe implementation
of `keySet`. This patch revises the `ClusterState` interface to offer more precise operations
and modifies `ClusterStateImpl` to makes all of these operations thread safe.

Diffs (updated)

  src/main/java/org/apache/aurora/scheduler/preemptor/ ce3bc7e6da3f86625c690e26c28ccef67ed9021a

  src/main/java/org/apache/aurora/scheduler/preemptor/ 42e2ca49b3c5de997cb5363e3518512d0f5a725e

  src/main/java/org/apache/aurora/scheduler/preemptor/ 506176769e172b7e9f4ba05c486fe6ab550fb5c3

  src/test/java/org/apache/aurora/scheduler/preemptor/ 49002d03b190b8642b6251f4d1fbd6663ee6becc


Testing (updated)

./gradlew build -Pq

If the approach is good, I can update this with benchmark information.


Zameer Manji

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message