aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zameer Manji" <zma...@apache.org>
Subject Re: Review Request 39670: Create immutable copy of offers for PendingTaskProcessor.
Date Tue, 27 Oct 2015 23:49:31 GMT


> On Oct. 26, 2015, 4:59 p.m., Stephan Erb wrote:
> > src/main/java/org/apache/aurora/scheduler/preemptor/PendingTaskProcessor.java, line
133
> > <https://reviews.apache.org/r/39670/diff/2/?file=1108519#file1108519line133>
> >
> >     Couldn't we run into the same `ConcurrentModificationException` if the offer
list is modified while `ImmutableList.copyOf()` is executed?

Good point, some more thought is required here.


- Zameer


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39670/#review104115
-----------------------------------------------------------


On Oct. 26, 2015, 4:16 p.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39670/
> -----------------------------------------------------------
> 
> (Updated Oct. 26, 2015, 4:16 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-1510
>     https://issues.apache.org/jira/browse/AURORA-1510
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> The PendingTaskProcessor runs concurrently with MesosSchedulerImpl. MesosSchedulerImpl
adds/removes offfers from OfferManager while PendingTaskProcessor iterates over the available
offers from OfferManager. Since OfferManager only returns an unmodifiable view of the underlying
list of offers, this causes a `ConcurrentModificationException`. To prevent this exception,
the PendingTaskProcessor takes an immutable copy of the offers before iterating over the list
of available offers.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/preemptor/PendingTaskProcessor.java 506176769e172b7e9f4ba05c486fe6ab550fb5c3

> 
> Diff: https://reviews.apache.org/r/39670/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message