aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Sweeney" <kevi...@apache.org>
Subject Re: Review Request 39563: Ignore serverInfo on the client side.
Date Thu, 22 Oct 2015 22:11:41 GMT


> On Oct. 22, 2015, 2:41 p.m., Kevin Sweeney wrote:
> > Elaborating - as far as I can see it the only sensible implementation of this feature
would be for the client to set the version in the *request* and for the scheduler to check
it and decide whether it supported the requested protocol version before processing it, and
for the *scheduler* to return something like HTTP's `501 Not Implemented`. Otherwise there
are no compatibility guarantees whatsoever. IMO `ServerInfo` should be much more like HTTP's
`Server` header - additional information the server can provide about itself.

This fixes compatibility with the released 0.9.0 scheduler though, which is the subject of
the linked ticket. As noted there's no reason to crash here. A scheduler change will not take
effect until 0.10.0.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39563/#review103662
-----------------------------------------------------------


On Oct. 22, 2015, 2:35 p.m., Kevin Sweeney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39563/
> -----------------------------------------------------------
> 
> (Updated Oct. 22, 2015, 2:35 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
> 
> 
> Bugs: AURORA-1522
>     https://issues.apache.org/jira/browse/AURORA-1522
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Ignore serverInfo on the client side.
> 
> The design of this check is flawed - the client has already sent an RPC to the scheduler
and received a response for it, meaning the request has already been processed and this check
only serves to ignore its results.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/api/scheduler_client.py 8e91788d8cb69ef21df6b045cd07f8cb111b95b3

>   src/test/python/apache/aurora/client/api/test_scheduler_client.py 10e8ebb4a12cc39d296cfde64ed9b01119d0aac3

> 
> Diff: https://reviews.apache.org/r/39563/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message