aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aurora ReviewBot" <>
Subject Re: Review Request 39563: Ignore serverInfo on the client side.
Date Thu, 22 Oct 2015 18:18:46 GMT

This is an automatically generated e-mail. To reply, visit:

Master (4eeec7a) is red with this patch.

  Using cached twitter.common.process-0.3.0.tar.gz
Collecting twitter.common.log==0.3.0 (from>twitter.checkstyle==0.1.0)
  Using cached twitter.common.log-0.3.0.tar.gz
Collecting twitter.common.util==0.3.0 (from>twitter.checkstyle==0.1.0)
  Using cached twitter.common.util-0.3.0.tar.gz
Collecting twitter.common.collections==0.3.0 (from>twitter.checkstyle==0.1.0)
  Using cached twitter.common.collections-0.3.0.tar.gz
Collecting smmap>=0.8.5 (from gitdb>=0.5.1->GitPython==0.3.2.RC1->twitter.checkstyle==0.1.0)
  Using cached smmap-0.9.0.tar.gz
Collecting twitter.common.string==0.3.0 (from twitter.common.process==0.3.0->>twitter.checkstyle==0.1.0)
  Using cached twitter.common.string-0.3.0.tar.gz
Collecting twitter.common.options==0.3.0 (from twitter.common.log==0.3.0->>twitter.checkstyle==0.1.0)
  Using cached twitter.common.options-0.3.0.tar.gz
Collecting twitter.common.dirutil==0.3.0 (from twitter.common.log==0.3.0->>twitter.checkstyle==0.1.0)
  Using cached twitter.common.dirutil-0.3.0.tar.gz
Collecting twitter.common.contextutil==0.3.0 (from twitter.common.util==0.3.0->>twitter.checkstyle==0.1.0)
  Using cached twitter.common.contextutil-0.3.0.tar.gz
Collecting twitter.common.lang==0.3.0 (from twitter.common.collections==0.3.0->>twitter.checkstyle==0.1.0)
  Using cached twitter.common.lang-0.3.0.tar.gz
Installing collected packages: pyflakes, pep8, smmap, gitdb, GitPython, twitter.common.lang,
twitter.common.string, twitter.common.process, twitter.common.options, twitter.common.dirutil,
twitter.common.log, twitter.common.contextutil, twitter.common.util, twitter.common.collections,, twitter.checkstyle
  Running install for pyflakes
  Running install for pep8
  Running install for smmap
  Running install for gitdb
  Running install for GitPython
  Running install for twitter.common.lang
  Running install for twitter.common.string
  Running install for twitter.common.process
  Running install for twitter.common.options
  Running install for twitter.common.dirutil
  Running install for twitter.common.log
  Running install for twitter.common.contextutil
  Running install for twitter.common.util
  Running install for twitter.common.collections
  Running install for
  Running install for twitter.checkstyle
Successfully installed GitPython-0.3.2rc1 gitdb-0.6.4 pep8-1.4.5 pyflakes-0.7.2 smmap-0.9.0
twitter.checkstyle-0.1.0 twitter.common.collections-0.3.0 twitter.common.contextutil-0.3.0
twitter.common.dirutil-0.3.0 twitter.common.lang-0.3.0 twitter.common.log-0.3.0 twitter.common.options-0.3.0
twitter.common.process-0.3.0 twitter.common.string-0.3.0 twitter.common.util-0.3.0
F401:ERROR   src/main/python/apache/aurora/client/api/ 'THRIFT_API_VERSION'
imported but unused
     |from gen.apache.aurora.api.constants import THRIFT_API_VERSION

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot

On Oct. 22, 2015, 5:47 p.m., Kevin Sweeney wrote:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> -----------------------------------------------------------
> (Updated Oct. 22, 2015, 5:47 p.m.)
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
> Bugs: AURORA-1522
> Repository: aurora
> Description
> -------
> Ignore serverInfo on the client side.
> The design of this check is flawed - the client has already sent an RPC to the scheduler
and received a response for it, meaning the request has already been processed and this check
only serves to ignore its results.
> Diffs
> -----
>   src/main/python/apache/aurora/client/api/ 8e91788d8cb69ef21df6b045cd07f8cb111b95b3

>   src/test/python/apache/aurora/client/api/ 10e8ebb4a12cc39d296cfde64ed9b01119d0aac3

> Diff:
> Testing
> -------
> Thanks,
> Kevin Sweeney

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message