aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Re: Review Request 39563: Ignore serverInfo on the client side.
Date Thu, 22 Oct 2015 18:02:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39563/#review103622
-----------------------------------------------------------



src/main/python/apache/aurora/client/api/scheduler_client.py 
<https://reviews.apache.org/r/39563/#comment161686>

    This change suggests we are effectively dropping the support for this feature. I agree
the design is flawed but probably not worth changing it now in view of REST API refactoring
though. 
    
    How about setting the version info in auth interceptor instead?


- Maxim Khutornenko


On Oct. 22, 2015, 5:47 p.m., Kevin Sweeney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39563/
> -----------------------------------------------------------
> 
> (Updated Oct. 22, 2015, 5:47 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
> 
> 
> Bugs: AURORA-1522
>     https://issues.apache.org/jira/browse/AURORA-1522
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Ignore serverInfo on the client side.
> 
> The design of this check is flawed - the client has already sent an RPC to the scheduler
and received a response for it, meaning the request has already been processed and this check
only serves to ignore its results.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/api/scheduler_client.py 8e91788d8cb69ef21df6b045cd07f8cb111b95b3

>   src/test/python/apache/aurora/client/api/test_scheduler_client.py 10e8ebb4a12cc39d296cfde64ed9b01119d0aac3

> 
> Diff: https://reviews.apache.org/r/39563/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message