aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Sweeney" <kevi...@apache.org>
Subject Re: Review Request 39532: Always set SessionKey to empty in the client.
Date Thu, 22 Oct 2015 17:57:06 GMT


> On Oct. 22, 2015, 10:42 a.m., Maxim Khutornenko wrote:
> > api/src/main/thrift/org/apache/aurora/gen/api.thrift, lines 56-62
> > <https://reviews.apache.org/r/39532/diff/3/?file=1103469#file1103469line56>
> >
> >     Why removing these fields now? This does not feel like a safe deprecation approach.

v0.9.0 schedulers ignore these fields, they just happen to call requireNonNull on this object.
In thrift it is always fine to send extra fields that the deserializer is unaware of; they
will simply be dropped on the floor.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39532/#review103612
-----------------------------------------------------------


On Oct. 22, 2015, 10:36 a.m., Kevin Sweeney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39532/
> -----------------------------------------------------------
> 
> (Updated Oct. 22, 2015, 10:36 a.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Always set SessionKey to empty on the client, as it's now ignored by the scheduler.
> 
> 
> Diffs
> -----
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift f0d4ef824562093492a8f3c9efa2059908f4d98b

>   src/main/python/apache/aurora/client/api/__init__.py 5847ca88b0aeb828e7d03538725b3430ecd209ab

>   src/main/python/apache/aurora/client/api/scheduler_client.py 8e91788d8cb69ef21df6b045cd07f8cb111b95b3

>   src/main/python/apache/aurora/common/auth/auth_module.py 53a3182896a9d385899e1f0274b2bfbe053076bb

>   src/main/python/apache/aurora/common/auth/auth_module_manager.py 73c6bd76989d97e4e6c336eb2fd9970b4c5e5b5c

>   src/test/python/apache/aurora/client/api/test_restarter.py 3b14d888b52241927a1005a518516174e907d7eb

>   src/test/python/apache/aurora/client/api/test_scheduler_client.py 10e8ebb4a12cc39d296cfde64ed9b01119d0aac3

>   src/test/python/apache/aurora/client/api/test_updater.py 87935553d37db8f0a1d03d3c370cf717b5277d74

> 
> Diff: https://reviews.apache.org/r/39532/diff/
> 
> 
> Testing
> -------
> 
> ./pants test.pytest --no-fast src/test/python/::                     
> 
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message