aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aurora ReviewBot" <wfar...@apache.org>
Subject Re: Review Request 39532: Always set SessionKey to empty in the client.
Date Thu, 22 Oct 2015 00:09:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39532/#review103493
-----------------------------------------------------------


Master (4eeec7a) is red with this patch.
  ./build-support/jenkins/build.sh

     ScheduleStatusResult,
     ServerInfo,
-    TaskConfig,
-    SessionKey)
-
+    SessionKey,
+    TaskConfig
+)
 
 SESSION_KEY = SessionKey()
 CLUSTER = 'east'
ERROR: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/api/test_updater.py
Imports are incorrectly sorted.
--- /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/api/test_updater.py:before
2015-10-22 00:04:12.282092
+++ /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/api/test_updater.py:after
2015-10-22 00:09:53.426362
@@ -53,11 +53,12 @@
     ScheduledTask,
     ScheduleStatusResult,
     ServerInfo,
+    SessionKey,
     TaskConfig,
     TaskConstraint,
     TaskQuery,
-    ValueConstraint,
-    SessionKey)
+    ValueConstraint
+)
 
 # Debug output helper -> enables log.* in source.
 if 'UPDATER_DEBUG' in environ:
ERROR: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/auth/auth_module.py
Imports are incorrectly sorted.
--- /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/auth/auth_module.py:before
2015-10-22 00:04:12.282092
+++ /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/auth/auth_module.py:after
2015-10-22 00:09:53.761672
@@ -14,7 +14,6 @@
 from abc import abstractmethod, abstractproperty
 
 from twitter.common.lang import Interface
-
 
 
 class AuthModule(Interface):


I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Oct. 21, 2015, 11:59 p.m., Kevin Sweeney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39532/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2015, 11:59 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Always set SessionKey to empty on the client, as it's now ignored by the scheduler.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/api/__init__.py 5847ca88b0aeb828e7d03538725b3430ecd209ab

>   src/main/python/apache/aurora/client/api/scheduler_client.py 8e91788d8cb69ef21df6b045cd07f8cb111b95b3

>   src/main/python/apache/aurora/common/auth/auth_module.py 53a3182896a9d385899e1f0274b2bfbe053076bb

>   src/main/python/apache/aurora/common/auth/auth_module_manager.py 73c6bd76989d97e4e6c336eb2fd9970b4c5e5b5c

>   src/test/python/apache/aurora/client/api/test_restarter.py 3b14d888b52241927a1005a518516174e907d7eb

>   src/test/python/apache/aurora/client/api/test_scheduler_client.py 10e8ebb4a12cc39d296cfde64ed9b01119d0aac3

>   src/test/python/apache/aurora/client/api/test_updater.py 87935553d37db8f0a1d03d3c370cf717b5277d74

> 
> Diff: https://reviews.apache.org/r/39532/diff/
> 
> 
> Testing
> -------
> 
> ./pants test.pytest --no-fast src/test/python/::                     
> 
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message