aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aurora ReviewBot" <wfar...@apache.org>
Subject Re: Review Request 39170: Fix NPE on accessing crons set at impossible dates
Date Fri, 09 Oct 2015 14:17:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39170/#review102055
-----------------------------------------------------------


Master (8816d49) is red with this patch.
  ./build-support/jenkins/build.sh


:commons:generateThriftResources
:commons:processResources
:commons:classes
:commons:jar
:compileJavaNote: Writing file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/org/apache/aurora/common/args/apt/cmdline.arg.info.txt.2
Note: Writing file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/META-INF/compiler/resource-mappings/org.apache.aurora.common.args.apt.CmdLineProcessor

:generateBuildProperties
:processResources
:classes
:jar
:startScripts
:distTar
:distZip
:assemble
:compileJmhJavaNote: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java
uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.

:processJmhResources UP-TO-DATE
:jmhClasses
:checkstyleJmh
:jsHint
:checkstyleMain[ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/cron/CronPredictor.java:17:
error: Wrong order for 'java.util.Date' import. Order should be: java, javax, scala, com,
net, org.         Each group should be separated by a single blank line.
[ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java:273:
error: 'if' construct must use '{}'s.
[ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java:276:
error: 'if' construct must use '{}'s.
 FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':checkstyleMain'.
> Checkstyle rule violations were found. See the report at: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/checkstyle/main.xml

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to
get more log output.

BUILD FAILED

Total time: 1 mins 46.098 secs


I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Oct. 9, 2015, 12:41 p.m., Brice Arnould wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39170/
> -----------------------------------------------------------
> 
> (Updated Oct. 9, 2015, 12:41 p.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Bugs: AURORA-1385
>     https://issues.apache.org/jira/browse/AURORA-1385
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This is for AURORA-1385
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/cron/CronPredictor.java 043ba7e6858db28001dfb07ea0c2ddf274a1c755

>   src/main/java/org/apache/aurora/scheduler/cron/quartz/CronPredictorImpl.java 1ddc4e1946910de798f7f423dd1b19ed56dece15

>   src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 13b5c222a0d7b9dd347990e6c09aac09ee566315

>   src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java 64cbd5b58d9254bb741e20e47165732e52569f70

> 
> Diff: https://reviews.apache.org/r/39170/diff/
> 
> 
> Testing
> -------
> 
> Added a specific unit test
> 
> 
> Thanks,
> 
> Brice Arnould
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message