aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Re: Review Request 39150: Converting to Range in ConfigGroup thrift.
Date Fri, 09 Oct 2015 01:32:47 GMT


> On Oct. 9, 2015, 12:01 a.m., David McLaughlin wrote:
> > This change is backwards incompatible. Shouldn't we add a new field that provides
the new type and deprecate the old field as per the deprecation policy?
> 
> Maxim Khutornenko wrote:
>     This API/struct were created for the UI. Given that there are no other known dependencies
and the fact that we are still on 0-major version, I'd consider this as an acceptable tradeoff
to minimize clutter. I wonder what others think, should we enforce our versioning guidelines
here?
> 
> Joshua Cohen wrote:
>     I think we need to assume there are users out there that use the thrift API in ways
we don't know about and we need to version accordingly. As much as I'd like to take the easy
route and just make the fix I think to be responsible maintainers of OSS we need to go through
a deprecation cycle.

Added deprecation note.


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39150/#review101985
-----------------------------------------------------------


On Oct. 9, 2015, 1:32 a.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39150/
> -----------------------------------------------------------
> 
> (Updated Oct. 9, 2015, 1:32 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Addressing a long standing TODO. Also some cleanup of unused util functions.
> 
> 
> Diffs
> -----
> 
>   NEWS 2edcea61fafea09b08faf03af4335ca82629d46d 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift a04e644453bfecde44ec7b51b53f42dc82e90c96

>   src/main/java/org/apache/aurora/scheduler/base/Numbers.java 5c1bdb4aeab285c46475a54bd13aeb780541fa08

>   src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 13b5c222a0d7b9dd347990e6c09aac09ee566315

>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java fd07365faa5fe516680600ed774d35c564948b9b

>   src/main/resources/scheduler/assets/js/controllers.js 85ae8ce9e51d1785e32ba3f2e4f31f35ec6f178d

>   src/main/resources/scheduler/assets/js/services.js b7699fe91d79f9a8141c8368da91443684b6994b

>   src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java 64cbd5b58d9254bb741e20e47165732e52569f70

> 
> Diff: https://reviews.apache.org/r/39150/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> Manual UI testing
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message