aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David McLaughlin" <da...@dmclaughlin.com>
Subject Re: Review Request 39150: Converting to Range in ConfigGroup thrift.
Date Fri, 09 Oct 2015 00:01:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39150/#review101985
-----------------------------------------------------------


This change is backwards incompatible. Shouldn't we add a new field that provides the new
type and deprecate the old field as per the deprecation policy?

- David McLaughlin


On Oct. 8, 2015, 11:35 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39150/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2015, 11:35 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Addressing a long standing TODO. Also some cleanup of unused util functions.
> 
> 
> Diffs
> -----
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift a04e644453bfecde44ec7b51b53f42dc82e90c96

>   src/main/java/org/apache/aurora/scheduler/base/Numbers.java 5c1bdb4aeab285c46475a54bd13aeb780541fa08

>   src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 13b5c222a0d7b9dd347990e6c09aac09ee566315

>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java fd07365faa5fe516680600ed774d35c564948b9b

>   src/main/resources/scheduler/assets/js/controllers.js 85ae8ce9e51d1785e32ba3f2e4f31f35ec6f178d

>   src/main/resources/scheduler/assets/js/services.js b7699fe91d79f9a8141c8368da91443684b6994b

>   src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java 64cbd5b58d9254bb741e20e47165732e52569f70

> 
> Diff: https://reviews.apache.org/r/39150/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> Manual UI testing
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message