aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aurora ReviewBot" <wfar...@apache.org>
Subject Re: Review Request 39143: Adding getJobUpdateDiff thrift API.
Date Thu, 08 Oct 2015 21:34:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39143/#review101959
-----------------------------------------------------------

Ship it!


Master (7408cb3) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Oct. 8, 2015, 9:09 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39143/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2015, 9:09 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Bill Farner.
> 
> 
> Bugs: AURORA-1515
>     https://issues.apache.org/jira/browse/AURORA-1515
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Adding the API to return update instructions. Note: Diff object will be extended later
to also return TaskConfig differences (blocked by AURORA-1517).
> 
> 
> Diffs
> -----
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift a04e644453bfecde44ec7b51b53f42dc82e90c96

>   src/main/java/org/apache/aurora/scheduler/base/Numbers.java 5c1bdb4aeab285c46475a54bd13aeb780541fa08

>   src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 13b5c222a0d7b9dd347990e6c09aac09ee566315

>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java fd07365faa5fe516680600ed774d35c564948b9b

>   src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java 64cbd5b58d9254bb741e20e47165732e52569f70

>   src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java d25618c19615ee097c1f2c4b6fefc70c565c649c

> 
> Diff: https://reviews.apache.org/r/39143/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message