aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joshua Cohen" <jco...@apache.org>
Subject Re: Review Request 39113: Use gradle 2.7 in builds.
Date Thu, 08 Oct 2015 04:07:17 GMT


> On Oct. 8, 2015, 3:56 a.m., Joshua Cohen wrote:
> > Mind adding a note to build.gradle in the aurora repo to update these as well whenever
updating the gradle version (maybe point to this review as an example)?
> 
> Bill Farner wrote:
>     The source of truth is in gradle/wrapper/gradle-wrapper.properties, which is actually
auto-generated when running `gradle wrapper`.  I could put it there anyway, but there's a
chance it could be squashed in the future if we re-generate the wrapper.  Given this context,
any thoughts?

Oh, I just sent out https://reviews.apache.org/r/39114/, which updated buildSrc/gradle.properties.
If that's not the right place I can discard.


- Joshua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39113/#review101853
-----------------------------------------------------------


On Oct. 8, 2015, 3:02 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39113/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2015, 3:02 a.m.)
> 
> 
> Review request for Aurora and Joshua Cohen.
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> -------
> 
> Necessary follow-up to https://reviews.apache.org/r/39095/, since the build is strict
about the gradle version used.
> 
> 
> Diffs
> -----
> 
>   builder/deb/ubuntu-trusty/Dockerfile a827c7a72ca507540dc7c08ff9ae3d16abf73d30 
>   specs/debian/control b286517a9cb6d2af79126ba2e8ca0e602aeab651 
>   specs/rpm/aurora.spec cf9c2715106a27fcb71447b5453ad3b847d2235a 
> 
> Diff: https://reviews.apache.org/r/39113/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message