Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7BFC818DF0 for ; Sun, 13 Sep 2015 19:55:20 +0000 (UTC) Received: (qmail 80286 invoked by uid 500); 13 Sep 2015 19:55:20 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 80231 invoked by uid 500); 13 Sep 2015 19:55:20 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 80197 invoked by uid 99); 13 Sep 2015 19:55:20 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 13 Sep 2015 19:55:20 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 02C2E1CF88C; Sun, 13 Sep 2015 19:55:19 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7801609421140762259==" MIME-Version: 1.0 Subject: Re: Review Request 38332: Convert all of our servlet implementations to jax-rs endpoints. From: "Zameer Manji" To: "Joshua Cohen" Cc: "Bill Farner" , "Zameer Manji" , "Aurora" Date: Sun, 13 Sep 2015 19:55:18 -0000 Message-ID: <20150913195518.3773.79924@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Zameer Manji" X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/38332/ X-Sender: "Zameer Manji" References: <20150913194921.3773.56437@reviews.apache.org> In-Reply-To: <20150913194921.3773.56437@reviews.apache.org> Reply-To: "Zameer Manji" X-ReviewRequest-Repository: aurora --===============7801609421140762259== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Sept. 13, 2015, 12:49 p.m., Zameer Manji wrote: > > Maybe we should move these endpoints out of commons and into org.apache.aurora.scheduler.http.endpoints? > > Bill Farner wrote: > If it's all the same to you, i'd like to save that for a follow-up to minimize diff churn. SGTM. - Zameer ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38332/#review98781 ----------------------------------------------------------- On Sept. 13, 2015, 11:06 a.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38332/ > ----------------------------------------------------------- > > (Updated Sept. 13, 2015, 11:06 a.m.) > > > Review request for Aurora and Joshua Cohen. > > > Repository: aurora > > > Description > ------- > > There are a few positive outcomes here: > > * our HTTP serving code is much more uniform > * endpoints have less boilerplate code > * endpoints are easier to test > * ServletModule setup is simpler and uniform > > > Diffs > ----- > > buildSrc/src/main/groovy/org/apache/aurora/build/CoverageReportCheck.groovy b996d4597492a76db0f2571db4e6c1ae9b4bcf33 > commons/src/main/java/org/apache/aurora/common/net/http/handlers/AbortHandler.java e97bd825752bf04cca391e2119b5e33c66a1cab5 > commons/src/main/java/org/apache/aurora/common/net/http/handlers/AssetHandler.java 7a44f07e8514f32637d1832273cb4d9081a14031 > commons/src/main/java/org/apache/aurora/common/net/http/handlers/ContentionPrinter.java 1f8c453c8e582da44849a8e922d974a0e054c638 > commons/src/main/java/org/apache/aurora/common/net/http/handlers/HealthHandler.java cc5ad4d5e15eaff78832c033e77b4ac0a532f6b3 > commons/src/main/java/org/apache/aurora/common/net/http/handlers/LogConfig.java 5520fb6a83d37884f6cace995f3cc3313c3980c4 > commons/src/main/java/org/apache/aurora/common/net/http/handlers/QuitHandler.java 4ce3c971b8e8ca696d7d5ea4e7d348237b836513 > commons/src/main/java/org/apache/aurora/common/net/http/handlers/StringTemplateServlet.java 60e0abb7f7bac4c84ece5e007a4b3980fbd9a585 > commons/src/main/java/org/apache/aurora/common/net/http/handlers/TextResponseHandler.java 23068eb4b8d9f1d848b4d007e14e7d32f3189ee1 > commons/src/main/java/org/apache/aurora/common/net/http/handlers/ThreadStackPrinter.java 5dd88041faafc563c87f51807476aa142e4942d5 > commons/src/main/java/org/apache/aurora/common/net/http/handlers/TimeSeriesDataSource.java e87fe2c2a2d2ed609273298eb57085bcb155c3b2 > commons/src/main/java/org/apache/aurora/common/net/http/handlers/VarsHandler.java bf04525115fa4045e792f2c45116e8d10addb24f > commons/src/main/java/org/apache/aurora/common/net/http/handlers/VarsJsonHandler.java e97ec6085c52a155ff9978c5121a5f98a8f93593 > commons/src/test/java/org/apache/aurora/common/net/http/handlers/AssetHandlerTest.java 740c42fedf668233b80f878728620a10ecf9b86f > commons/src/test/java/org/apache/aurora/common/net/http/handlers/VarsHandlerTest.java 34f62fb9db2d723f8ef171db7c7b485d8416d24f > config/legacy_untested_classes.txt 07fd5f1066a4d926072d91b9de170b9035fb3ea4 > src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java c503dcceb417d1f73c30dc63cf5352470d4c761d > src/test/java/org/apache/aurora/scheduler/app/local/LocalSchedulerMain.java 738c8b644287b93372f3227832a9d92b95dc498a > > Diff: https://reviews.apache.org/r/38332/diff/ > > > Testing > ------- > > manually clicked through everything i could think of in ./gradlew run and in vagrant > end-to-end tests > > > Thanks, > > Bill Farner > > --===============7801609421140762259==--