Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E849218FD9 for ; Fri, 11 Sep 2015 18:59:02 +0000 (UTC) Received: (qmail 27824 invoked by uid 500); 11 Sep 2015 18:59:02 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 27775 invoked by uid 500); 11 Sep 2015 18:59:02 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 27750 invoked by uid 99); 11 Sep 2015 18:59:02 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 11 Sep 2015 18:59:02 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 6840C27307B; Fri, 11 Sep 2015 18:59:01 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0984901552241431607==" MIME-Version: 1.0 Subject: Re: Review Request 38313: Showing all resource consumption details in the UI From: "Joshua Cohen" To: "Joshua Cohen" , "Bill Farner" Cc: "Maxim Khutornenko" , "Aurora" Date: Fri, 11 Sep 2015 18:59:01 -0000 Message-ID: <20150911185901.1695.5369@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Joshua Cohen" X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/38313/ X-Sender: "Joshua Cohen" References: <20150911185523.1695.17010@reviews.apache.org> In-Reply-To: <20150911185523.1695.17010@reviews.apache.org> Reply-To: "Joshua Cohen" X-ReviewRequest-Repository: aurora --===============0984901552241431607== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38313/#review98664 ----------------------------------------------------------- File Attachment: resources.png - resources.png Couple of suggestions on this format: 1) what do you think about moving the unit into the header, rather than repeating it on every line? E.g.: CPU (cores) | RAM (MiB) | Disk (MiB). 2) Maybe right align the numeric values? Otherwise looks good to me! - Joshua Cohen On Sept. 11, 2015, 6:55 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38313/ > ----------------------------------------------------------- > > (Updated Sept. 11, 2015, 6:55 p.m.) > > > Review request for Aurora, Joshua Cohen and Bill Farner. > > > Repository: aurora > > > Description > ------- > > Also, rotated resources table for better UX. > > > Diffs > ----- > > src/main/resources/scheduler/assets/js/controllers.js 511f5c3e0c55bc81b3f41ed23109a8f03188c589 > src/main/resources/scheduler/assets/role.html d3a4c7dae7f187081c6f0521912dc23f3ec8a871 > > Diff: https://reviews.apache.org/r/38313/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > resources.png > https://reviews.apache.org/media/uploaded/files/2015/09/11/763459b0-0c1a-45be-826e-ffaa613cc719__resources.png > > > Thanks, > > Maxim Khutornenko > > --===============0984901552241431607==--