Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BF540182FB for ; Tue, 1 Sep 2015 19:03:23 +0000 (UTC) Received: (qmail 22887 invoked by uid 500); 1 Sep 2015 19:03:23 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 22833 invoked by uid 500); 1 Sep 2015 19:03:23 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 22809 invoked by uid 99); 1 Sep 2015 19:03:23 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Sep 2015 19:03:23 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 97BA226CB78; Tue, 1 Sep 2015 19:03:21 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3896706340533100696==" MIME-Version: 1.0 Subject: Re: Review Request 38014: Remove StartupRegistry. From: "Aurora ReviewBot" To: "Zameer Manji" , "Kevin Sweeney" Cc: "Bill Farner" , "Aurora ReviewBot" , "Aurora" Date: Tue, 01 Sep 2015 19:03:21 -0000 Message-ID: <20150901190321.17241.21319@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Aurora ReviewBot" X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/38014/ X-Sender: "Aurora ReviewBot" References: <20150901185917.17241.2629@reviews.apache.org> In-Reply-To: <20150901185917.17241.2629@reviews.apache.org> Reply-To: "Aurora ReviewBot" X-ReviewRequest-Repository: aurora --===============3896706340533100696== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38014/#review97321 ----------------------------------------------------------- Ship it! Master (5a7bd34) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Sept. 1, 2015, 6:59 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38014/ > ----------------------------------------------------------- > > (Updated Sept. 1, 2015, 6:59 p.m.) > > > Review request for Aurora, Kevin Sweeney and Zameer Manji. > > > Repository: aurora > > > Description > ------- > > Remove StartupRegistry. > > > Diffs > ----- > > commons/src/main/java/org/apache/aurora/common/application/AppLauncher.java 78ed7d0aae50c976eba9045b17587258edc588b0 > commons/src/main/java/org/apache/aurora/common/application/StartupRegistry.java 997ee77dd8f6e02c2becddf98e16cbbbeec4cb4f > commons/src/main/java/org/apache/aurora/common/application/StartupStage.java 80509010f37894108881d40cad9d8ade8610f309 > commons/src/main/java/org/apache/aurora/common/application/modules/LifecycleModule.java 1b6bd086a5a434cb7e4b92ed9cfd252e2518ba66 > commons/src/main/java/org/apache/aurora/common/application/modules/StatsModule.java 3959ce3d688dd50399185925d91f0014fc1c43f9 > commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepository.java 6928e48073d152915ca42b6f46236b21c0882086 > commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepositoryImpl.java 387e379a9c84d663f2af23e4760754a023219860 > config/legacy_untested_classes.txt 4bae43a43d00f71456f37f001fcd21ce6a2fb841 > src/main/java/org/apache/aurora/GuavaUtils.java e3e90e3e43744463a2f00552f0041d0d1945bd57 > src/main/java/org/apache/aurora/scheduler/SchedulerServicesModule.java 1077816b696c4d2e97aafa59900b6acf2adce064 > src/main/java/org/apache/aurora/scheduler/app/AppModule.java 6892a70042e25fd672475517325b4e4b69a0adab > src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 8047622e206c9827e5cd8e40152a278d495bd0ff > src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 1a25924d789295c5950947f5e302e1d1fbec68f2 > src/test/java/org/apache/aurora/scheduler/app/local/simulator/ClusterSimulatorModule.java 4af49d5dcb1925c4055f5ada8601f6fcab5d7d00 > src/test/java/org/apache/aurora/scheduler/events/PubsubEventModuleTest.java cb38c3e047efac483445f43b941c7eea8862cc9c > src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java ed8e8119ac3dc41c18316a1ca6e34c178916b09d > src/test/java/org/apache/aurora/scheduler/preemptor/PreemptorModuleTest.java 3f045ff38d672266ce2e2bb26f729b0ca4657e81 > > Diff: https://reviews.apache.org/r/38014/diff/ > > > Testing > ------- > > test suite > ./gradlew run > end-to-end tests > > > Thanks, > > Bill Farner > > --===============3896706340533100696==--