Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9233B17D6E for ; Tue, 1 Sep 2015 17:17:26 +0000 (UTC) Received: (qmail 49333 invoked by uid 500); 1 Sep 2015 17:17:21 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 49284 invoked by uid 500); 1 Sep 2015 17:17:21 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 49261 invoked by uid 99); 1 Sep 2015 17:17:21 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Sep 2015 17:17:21 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 988D526DA6C; Tue, 1 Sep 2015 17:17:19 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5085368256028538455==" MIME-Version: 1.0 Subject: Review Request 38010: Stop in-progress instances from pulsing when update has been aborted. From: "Joshua Cohen" To: "Bill Farner" , "David McLaughlin" Cc: "Joshua Cohen" , "Aurora" Date: Tue, 01 Sep 2015 17:17:19 -0000 Message-ID: <20150901171719.17241.92801@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Joshua Cohen" X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/38010/ X-Sender: "Joshua Cohen" Reply-To: "Joshua Cohen" X-ReviewRequest-Repository: aurora --===============5085368256028538455== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38010/ ----------------------------------------------------------- Review request for Aurora, David McLaughlin and Bill Farner. Repository: aurora Description ------- Stop in-progress instances from pulsing when update has been aborted. Also removed the "INSTANCE-" prefix from tooltip as it seemed superfluous and added "ABORTED" to the tooltip for instances that were "UPDATING" when the update was aborted. An argument can be made for adding "ABORTED" to the tooltip for all non-terminal states (PENDING, etc.), let me know if you think we should add it for those as well. Diffs ----- src/main/resources/scheduler/assets/css/app.css 9437c53e695d1c4009d9df5fb23e34479f5b3d2d src/main/resources/scheduler/assets/js/directives.js d8f722c441b9399e7eacd6ae29966b3fb24a422d src/main/resources/scheduler/assets/update.html c8867093338593e5561e42fdee7cc5f15be0356e Diff: https://reviews.apache.org/r/38010/diff/ Testing ------- ./gradlew jshint Verified the pulsing stops for an aborted update. Also see screenshot for tooltip changes. File Attachments ---------------- Screen Shot 2015-09-01 at 12.08.51 PM.png https://reviews.apache.org/media/uploaded/files/2015/09/01/340c71be-564f-4024-8ee3-bab960edfad0__Screen_Shot_2015-09-01_at_12.08.51_PM.png Thanks, Joshua Cohen --===============5085368256028538455==--