aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Sweeney" <kevi...@apache.org>
Subject Re: Review Request 38906: Use Shiro to generate audit messages when available.
Date Wed, 30 Sep 2015 21:31:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38906/
-----------------------------------------------------------

(Updated Sept. 30, 2015, 2:31 p.m.)


Review request for Aurora, Maxim Khutornenko and Zameer Manji.


Changes
-------

Fix FindBugs and CheckStyle.


Repository: aurora


Description
-------

This ensures that Shiro is always used to generate audit messages when available.


Diffs (updated)
-----

  src/main/java/org/apache/aurora/scheduler/thrift/AuditMessages.java PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java d69bc3947c4a791cac97212cedf44250be273524

  src/test/java/org/apache/aurora/scheduler/thrift/AuditMessagesTest.java PRE-CREATION 
  src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java ac89618332926d5a25fe7ab7da3b270b4d42c723

  src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 4bd8b12996cbfc7d75a994033551374b32909511


Diff: https://reviews.apache.org/r/38906/diff/


Testing
-------

./gradlew build


Thanks,

Kevin Sweeney


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message