aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Renan DelValle" <rdelv...@binghamton.edu>
Subject Re: Review Request 37818: Moved executor settings configuration to loadable JSON
Date Wed, 30 Sep 2015 21:10:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37818/
-----------------------------------------------------------

(Updated Sept. 30, 2015, 9:10 p.m.)


Review request for Aurora and Bill Farner.


Changes
-------

Fixed bug that was causing end to end tests to fail. Needed to add an arg0. Fixed docker creation,
docker commandinfo's are still generated like they used to and run with shell as true due
to the fact that an environmental var is needed to run the tasks.

@ReviewBot retry


Repository: aurora


Description
-------

This is the first stage in a series of patches to create support for custom executors. In
an effort to expedite the review process, I have decided to break down my patch into multiple
pieces that when/if commited won't break the trunk.

This patch includes the ability to load configuration from a JSON file. A JSON example file
is included in examples/vagrant/executors-config.json

Command line arguments have been eliminated and moved over to the JSON file. Jackson is used
to deserialize a CommandInfo.Builder along with two other fields. Volumes are now based on
the Protobuf version and not the Aurora Thrift version.


Diffs (updated)
-----

  NEWS 2edcea61fafea09b08faf03af4335ca82629d46d 
  build.gradle 0401a9cbf0caf5578ef3c30e67c5b6a0a7a74a03 
  examples/vagrant/executors-config.json PRE-CREATION 
  examples/vagrant/upstart/aurora-scheduler-kerberos.conf 4f43892723db4744db205ea7dd107e9e9ce9d5db

  examples/vagrant/upstart/aurora-scheduler.conf 4033184451f36cb5f0233ea96e3dceaae6741275

  src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java c210c0db07bb1f4b3f76668178dcd7e2de56a4ac

  src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java 197184b6edc0768d677636341b5737f262abdf7d

  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 99b874459c358c67234c6fe748e6427f313a04a8

  src/main/java/org/apache/aurora/scheduler/base/CommandUtil.java aa5ce8b2f14c7dbd0eae120018ee41387c26059f

  src/main/java/org/apache/aurora/scheduler/configuration/ExecutorSettingsLoader.java PRE-CREATION

  src/main/java/org/apache/aurora/scheduler/mesos/ExecutorSettings.java b3c913892248e4a9a8111412307463985f5ca97f

  src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java f6ba2c40aea555d3e0ab774218bfe08d7e1c984b

  src/test/java/org/apache/aurora/scheduler/ResourceSlotTest.java 6fad3344042dc6a75cdf74ce79d388fcd4fc9861

  src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java f63d6f12d114c062f81137ffc0b1078837e3cf76

  src/test/java/org/apache/aurora/scheduler/base/CommandUtilTest.java cd0295780d41bc4e914583f195b37eaed28a46dc

  src/test/java/org/apache/aurora/scheduler/configuration/ExecutorSettingsLoaderTest.java
PRE-CREATION 
  src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java dddf7952d3f0e508cd736d5fb95e573267708d43

  src/test/java/org/apache/aurora/scheduler/mesos/TaskExecutors.java d0987251b058988fcbfab16c1b138c37e0c5b8c6

  src/test/resources/org/apache/aurora/scheduler/configuration/multiple-executor-example.json
PRE-CREATION 
  src/test/resources/org/apache/aurora/scheduler/configuration/single-executor-example.json
PRE-CREATION 
  src/test/resources/org/apache/aurora/scheduler/configuration/thermos-no-observer.json PRE-CREATION


Diff: https://reviews.apache.org/r/37818/diff/


Testing (updated)
-------

./build-support/jenkins/build.sh: directory sandbox failed but it may be a flaky test
bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh


Thanks,

Renan DelValle


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message