aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aurora ReviewBot" <wfar...@apache.org>
Subject Re: Review Request 38904: Clean up instance id range display. Also remove deprecated max time until running, since it's unused by the server updater.
Date Wed, 30 Sep 2015 20:05:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38904/#review101145
-----------------------------------------------------------


Master (745654b) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Sept. 30, 2015, 7:46 p.m., Joshua Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38904/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2015, 7:46 p.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Clean up instance id range display. Also remove deprecated max time until running, since
it's unused by the server updater.
> 
> 
> Diffs
> -----
> 
>   src/main/resources/scheduler/assets/js/filters.js bf6aef86fd50ba38b64f5d9f481d6915c38881f7

>   src/main/resources/scheduler/assets/updateSettings.html 611788f8a517fef5ab451ef2c3491fcaf0fffb34

> 
> Diff: https://reviews.apache.org/r/38904/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew jsHint
> 
> Verified no instance id range output in vagrant (see attached screenshots).
> 
> 
> File Attachments
> ----------------
> 
> Before
>   https://reviews.apache.org/media/uploaded/files/2015/09/30/71674c02-689b-4818-adaf-7fe005a25c52__Screen_Shot_2015-09-30_at_2.33.27_PM.png
> After
>   https://reviews.apache.org/media/uploaded/files/2015/09/30/552cd5f9-2a8c-4a8c-9fd4-50afcafe187a__Screen_Shot_2015-09-30_at_2.45.28_PM.png
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message