aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aurora ReviewBot" <wfar...@apache.org>
Subject Re: Review Request 38841: Drop commons-io dependency.
Date Tue, 29 Sep 2015 21:25:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38841/#review101022
-----------------------------------------------------------

Ship it!


Master (5627611) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Sept. 29, 2015, 9:11 p.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38841/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2015, 9:11 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This drops the commons-io dependency by replacing the usages with a built in Junit rule.
> 
> 
> Diffs
> -----
> 
>   build.gradle 5195cca1f52d2a39868faf9b3c62a2395f9ba489 
>   commons/src/main/java/org/apache/aurora/common/zookeeper/testing/BaseZooKeeperTest.java
170d37bff0eb32d347d0adebc4aa6e8395acc056 
>   commons/src/main/java/org/apache/aurora/common/zookeeper/testing/ZooKeeperTestServer.java
ac5d64a83529ca7358b8e9576293af729654325e 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 1530ef8b7e12e7514e01f1ed6cd3c171a2d71e72

>   src/test/java/org/apache/aurora/scheduler/storage/backup/RecoveryTest.java 1e4e62515d1ad6bb2fb44efdd5be225c71d42e53

>   src/test/java/org/apache/aurora/scheduler/storage/backup/StorageBackupTest.java 18dbd2f7d127c95e7bf2624e9f9dda69bb7a42d4

> 
> Diff: https://reviews.apache.org/r/38841/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew clean test
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message