aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joe Smith" <yasumo...@gmail.com>
Subject Review Request 38510: Maintain compatibility with Health Handler before javax refactor
Date Fri, 18 Sep 2015 21:59:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38510/
-----------------------------------------------------------

Review request for Aurora and Maxim Khutornenko.


Bugs: AURORA-1496
    https://issues.apache.org/jira/browse/AURORA-1496


Repository: aurora


Description
-------

Maintain compatibility with Health Handler before javax refactor


Diffs
-----

  commons/src/main/java/org/apache/aurora/common/net/http/handlers/HealthHandler.java 731151c2b14e2edc3284c56a9a9f0aa56d8b37f9


Diff: https://reviews.apache.org/r/38510/diff/


Testing
-------

The previous HealthHandler used `println` to get the newline.

`[tw-mbp-jsmith aurora (health-newline)]$ src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh`

and

```
vagrant@aurora:~$ curl --silent --fail --retry 4 --retry-delay 10 localhost:8081/health
OK
vagrant@aurora:~$ 
```


Thanks,

Joe Smith


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message