aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 38390: Adding oversubscription summary.
Date Tue, 15 Sep 2015 01:20:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38390/#review98977
-----------------------------------------------------------



docs/configuration-reference.md (line 332)
<https://reviews.apache.org/r/38390/#comment155751>

    This could use a more objective statement about what the flag _is_ rather than that it
intends to be.



docs/configuration-reference.md (lines 344 - 355)
<https://reviews.apache.org/r/38390/#comment155759>

    Tiers seems like a significant enough topic to warrant its own page with some more context
and better flow.  As it stands, it's really hard to understand what exactly a tier is and
why i want or need to define them. 
    
    Also, you might consider dropping the term 'best-effort' and stick to 'revocable' to avoid
overloading the naming.



docs/deploying-aurora-scheduler.md (line 201)
<https://reviews.apache.org/r/38390/#comment155755>

    Would it make sense to remove this flag, and instead enable revocable resources when there's
at least one configured tier that uses them?


- Bill Farner


On Sept. 14, 2015, 5:54 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38390/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2015, 5:54 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1441
>     https://issues.apache.org/jira/browse/AURORA-1441
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Adding oversubscription summary.
> 
> 
> Diffs
> -----
> 
>   docs/configuration-reference.md ad2701cadd38bb2fdbbe2acc477038986f8ec733 
>   docs/deploying-aurora-scheduler.md 8db0e615b6abe6865a889dbcfb24271655caaee6 
> 
> Diff: https://reviews.apache.org/r/38390/diff/
> 
> 
> Testing
> -------
> 
> Private remote: https://github.com/maxim111333/incubator-aurora/blob/oversubscription_docs/docs/
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message