aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jake Farrell" <>
Subject Review Request 38389: AURORA-1485: TaskConfig default container value breaks client library generation for GO
Date Tue, 15 Sep 2015 00:41:22 GMT

This is an automatically generated e-mail. To reply, visit:

Review request for Aurora.

Bugs: AURORA-1485

Repository: aurora


When generating the client api library for go the default containerizer used as a hack for
AURORA-1185 breaks and causes the client lib to not be generated correctly. The default value
for the optional field `container = { "mesos": {} }` is not necessary as it is defaulted in
java code on the api side.

Tracking this down it looks like the default value was a last minute addition based on some
review comments and is not necessary or used anywhere.


  api/src/main/thrift/org/apache/aurora/gen/api.thrift 24a2ca8cc9a236228fdd8aa61c877319a803c9a6

  src/test/java/org/apache/aurora/scheduler/cron/quartz/ 13cb73d0e314c043aed9ab2aacea1908c069a297

  src/test/python/apache/aurora/client/cli/ a75f15e99af97acb0af7e112e28c693a77f9eb24

  src/test/python/apache/aurora/client/cli/ b03148b4edaa334620a72bee1937c8c16e19f23e

  src/test/python/apache/aurora/executor/ d24c61162e11bb4afef2902ebb031478fe3ed247



Passes all java/py tests in ./build-support/jenkins/
Passes all e2e tests in ./src/test/sh/org/apache/aurora/e2e/


Jake Farrell

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message