aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jake Farrell" <jfarr...@apache.org>
Subject Review Request 38389: AURORA-1485: TaskConfig default container value breaks client library generation for GO
Date Tue, 15 Sep 2015 00:41:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38389/
-----------------------------------------------------------

Review request for Aurora.


Bugs: AURORA-1485
    https://issues.apache.org/jira/browse/AURORA-1485


Repository: aurora


Description
-------

When generating the client api library for go the default containerizer used as a hack for
AURORA-1185 breaks and causes the client lib to not be generated correctly. The default value
for the optional field `container = { "mesos": {} }` is not necessary as it is defaulted in
java code on the api side.

Tracking this down it looks like the default value was a last minute addition based on some
review comments and is not necessary or used anywhere.


Diffs
-----

  api/src/main/thrift/org/apache/aurora/gen/api.thrift 24a2ca8cc9a236228fdd8aa61c877319a803c9a6

  src/test/java/org/apache/aurora/scheduler/cron/quartz/QuartzTestUtil.java 13cb73d0e314c043aed9ab2aacea1908c069a297

  src/test/python/apache/aurora/client/cli/test_status.py a75f15e99af97acb0af7e112e28c693a77f9eb24

  src/test/python/apache/aurora/client/cli/util.py b03148b4edaa334620a72bee1937c8c16e19f23e

  src/test/python/apache/aurora/executor/test_thermos_executor.py d24c61162e11bb4afef2902ebb031478fe3ed247


Diff: https://reviews.apache.org/r/38389/diff/


Testing
-------

Passes all java/py tests in ./build-support/jenkins/build.sh
Passes all e2e tests in ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh


Thanks,

Jake Farrell


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message