aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aurora ReviewBot" <wfar...@apache.org>
Subject Re: Review Request 38332: Convert all of our servlet implementations to jax-rs endpoints.
Date Sun, 13 Sep 2015 00:37:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38332/#review98757
-----------------------------------------------------------


Master (5dccf92) is red with this patch.
  ./build-support/jenkins/build.sh


:processJmhResources UP-TO-DATE
:jmhClasses
:checkstyleJmh
:jsHint
:checkstyleMain
:compileTestJavaNote: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.

:processTestResources
:testClasses
:checkstyleTest
:findbugsJmh
:findbugsMain
:findbugsTest
:licenseJmh UP-TO-DATE
:licenseMain UP-TO-DATE
:licenseTest UP-TO-DATE
:license UP-TO-DATE
:pmdMain
:test
:jacocoTestReport
Coverage report generated: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/jacoco/test/html/index.html
:analyzeReport
Instruction coverage of 0.8908805416207839 exceeds minimum coverage of 0.89.
Branch coverage is 0.8171846435100548, but must be greater than 0.835
:analyzeReport FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':analyzeReport'.
> Test coverage missing for org/apache/aurora/scheduler/http/AbortCallback

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to
get more log output.

BUILD FAILED

Total time: 4 mins 55.156 secs


I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Sept. 13, 2015, 12:24 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38332/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2015, 12:24 a.m.)
> 
> 
> Review request for Aurora and Joshua Cohen.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> There are a few positive outcomes here:
> 
> * our HTTP serving code is much more uniform
> * endpoints have less boilerplate code
> * endpoints are easier to test
> * ServletModule setup is simpler and uniform
> 
> 
> Diffs
> -----
> 
>   commons/src/main/java/org/apache/aurora/common/net/http/handlers/AbortHandler.java
e97bd825752bf04cca391e2119b5e33c66a1cab5 
>   commons/src/main/java/org/apache/aurora/common/net/http/handlers/AssetHandler.java
7a44f07e8514f32637d1832273cb4d9081a14031 
>   commons/src/main/java/org/apache/aurora/common/net/http/handlers/ContentionPrinter.java
1f8c453c8e582da44849a8e922d974a0e054c638 
>   commons/src/main/java/org/apache/aurora/common/net/http/handlers/HealthHandler.java
cc5ad4d5e15eaff78832c033e77b4ac0a532f6b3 
>   commons/src/main/java/org/apache/aurora/common/net/http/handlers/LogConfig.java 5520fb6a83d37884f6cace995f3cc3313c3980c4

>   commons/src/main/java/org/apache/aurora/common/net/http/handlers/QuitHandler.java 4ce3c971b8e8ca696d7d5ea4e7d348237b836513

>   commons/src/main/java/org/apache/aurora/common/net/http/handlers/StringTemplateServlet.java
60e0abb7f7bac4c84ece5e007a4b3980fbd9a585 
>   commons/src/main/java/org/apache/aurora/common/net/http/handlers/TextResponseHandler.java
23068eb4b8d9f1d848b4d007e14e7d32f3189ee1 
>   commons/src/main/java/org/apache/aurora/common/net/http/handlers/ThreadStackPrinter.java
5dd88041faafc563c87f51807476aa142e4942d5 
>   commons/src/main/java/org/apache/aurora/common/net/http/handlers/TimeSeriesDataSource.java
e87fe2c2a2d2ed609273298eb57085bcb155c3b2 
>   commons/src/main/java/org/apache/aurora/common/net/http/handlers/VarsHandler.java bf04525115fa4045e792f2c45116e8d10addb24f

>   commons/src/main/java/org/apache/aurora/common/net/http/handlers/VarsJsonHandler.java
e97ec6085c52a155ff9978c5121a5f98a8f93593 
>   commons/src/test/java/org/apache/aurora/common/net/http/handlers/AssetHandlerTest.java
740c42fedf668233b80f878728620a10ecf9b86f 
>   commons/src/test/java/org/apache/aurora/common/net/http/handlers/VarsHandlerTest.java
34f62fb9db2d723f8ef171db7c7b485d8416d24f 
>   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java c503dcceb417d1f73c30dc63cf5352470d4c761d

>   src/test/java/org/apache/aurora/scheduler/app/local/LocalSchedulerMain.java 738c8b644287b93372f3227832a9d92b95dc498a

> 
> Diff: https://reviews.apache.org/r/38332/diff/
> 
> 
> Testing
> -------
> 
> manually clicked through everything i could think of in ./gradlew run and in vagrant
> end-to-end tests
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message