aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 38331: Refactor SchedulerMain to absorb AppLauncher.
Date Sat, 12 Sep 2015 20:28:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38331/#review98754
-----------------------------------------------------------


Added reviewer notes.


commons/src/main/java/org/apache/aurora/common/application/Lifecycle.java 
<https://reviews.apache.org/r/38331/#comment155338>

    This is now set up in `SchedulerMain`, since we don't ever change our uncaught exception
handler.



config/checkstyle/suppressions.xml (line 22)
<https://reviews.apache.org/r/38331/#comment155339>

    This is a result of moving some bits from AppLauncher that legitimately use `System.exit()`,
subjecting that code to checkstyle checks.  Twitter commons has the same suppression [1].
    
    [1] https://github.com/twitter/commons/blob/master/build-support/commons/checkstyle/checkstyle_suppressions.xml#L38-L39



src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
<https://reviews.apache.org/r/38331/#comment155340>

    This was pushed out and bound externally, so we no longer have to plumb `clusterName`.



src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
<https://reviews.apache.org/r/38331/#comment155341>

    This class turned into a binding catch-all, so i broke these bindings out into `ServiceDiscoveryModule`
installed externally.



src/main/java/org/apache/aurora/scheduler/app/Modules.java (line 25)
<https://reviews.apache.org/r/38331/#comment155342>

    I renamed this to avoid a name clash with guava's Modules.



src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java (line 194)
<https://reviews.apache.org/r/38331/#comment155343>

    There are 3 ways this class is used:
    
    2 call paths:
    SchedulerMain.main -> SchedulerMain.flagConfiguredMain LocalSchedulerMain.main ->
SchedulerMain.flagConfiguredMain
    
    1 exposure of most modules (getUniversalModules) for SchedulerIT



src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java (lines 256 - 271)
<https://reviews.apache.org/r/38331/#comment155344>

    This was all pulled in from AppLauncher, simplified slightly because it is no longer generic.



src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java (lines 279 - 282)
<https://reviews.apache.org/r/38331/#comment155345>

    Things requiring libmesos.so go here.


- Bill Farner


On Sept. 12, 2015, 1:16 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38331/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2015, 1:16 p.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> I also did some long-overdue module cleanup in this effort, making it unnecessary to
pass arguments through several layers.
> Another nice side-effect is that `LocalSchedulerMain` no longer extends `SchedulerMain`,
which i find to be a much cleaner arrangement.
> 
> 
> Diffs
> -----
> 
>   commons/src/main/java/org/apache/aurora/common/application/AppLauncher.java 64968702e01dd8831431d6f031291e776480d7f6

>   commons/src/main/java/org/apache/aurora/common/application/Application.java ebe01e8be06e24bc04e25e3b58b50ecb1ce73c7e

>   commons/src/main/java/org/apache/aurora/common/application/Lifecycle.java 5d22a2aea5b6f311c528180ed7610e1874f8242c

>   commons/src/main/java/org/apache/aurora/common/application/modules/AppLauncherModule.java
1c08f7e756e9a97ffa7a6db75cbec1f48150d8da 
>   config/checkstyle/checkstyle.xml 9c291f5cc4d70e6c920cbf033a2f5fee18f33229 
>   config/checkstyle/suppressions.xml PRE-CREATION 
>   config/legacy_untested_classes.txt 07fd5f1066a4d926072d91b9de170b9035fb3ea4 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 78071ed5cceed55e1fa4ba3fe55a4a60a0ff2fdf

>   src/main/java/org/apache/aurora/scheduler/app/Modules.java cad7c38ca62767093c23923ff83d7aefda6dc54f

>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 11f04da3783677208347873e5e7c92aad6b98f40

>   src/main/java/org/apache/aurora/scheduler/app/ServiceDiscoveryModule.java PRE-CREATION

>   src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java
f317b68638ce65ca204d0a9d93e9eb299339d2ec 
>   src/main/java/org/apache/aurora/scheduler/http/api/security/ModuleParser.java 63ab9550e32e41632cc4f2aa32a63c725d93bf7e

>   src/main/java/org/apache/aurora/scheduler/thrift/auth/ThriftAuthModule.java 3ccee66e655ef3a27681c7aa4b0a2ffd77fac51e

>   src/test/java/org/apache/aurora/scheduler/SchedulerLifecycleTest.java d9f7b2095aa4c5306e57ec6f421eadba82e18ede

>   src/test/java/org/apache/aurora/scheduler/app/ModulesTest.java 01137e9e6862f64382de83a07af197d1b9e2f09d

>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 49411289299bfc230e8c6e0ce6fa96e619f57524

>   src/test/java/org/apache/aurora/scheduler/app/local/LocalSchedulerMain.java 738c8b644287b93372f3227832a9d92b95dc498a

>   src/test/java/org/apache/aurora/scheduler/http/QuitCallbackTest.java e50bdc511c597349e791d2c6dae356fc2f0e69fc

>   src/test/java/org/apache/aurora/scheduler/log/mesos/MesosLogTest.java cb33b0371f8ac45e0fd7437a88160e7c5b5629ff

>   src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java 7e1d13b00a1422993ac0cf3fe55082d6ae3204dd

>   src/test/java/org/apache/aurora/scheduler/sla/SlaModuleTest.java 3e9ef105c550b8aa6620aad8fb37e3f2e889da42

> 
> Diff: https://reviews.apache.org/r/38331/diff/
> 
> 
> Testing
> -------
> 
> unit tests
> end-to-end tests
> ./gradlew run
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message