aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zameer Manji" <zma...@apache.org>
Subject Re: Review Request 38315: Change ZooKeeperTestServer to not rely on ShutdownRegistry.
Date Fri, 11 Sep 2015 20:52:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38315/#review98684
-----------------------------------------------------------

Ship it!



commons/src/main/java/org/apache/aurora/common/application/AppLauncher.java (line 95)
<https://reviews.apache.org/r/38315/#comment155218>

    Shouldn't we log this instead of printing it?


- Zameer Manji


On Sept. 11, 2015, 1:34 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38315/
> -----------------------------------------------------------
> 
> (Updated Sept. 11, 2015, 1:34 p.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This is the first of 2-3 steps to replace ShutdownRegistry with Services.  Note that
some sources needed to move, requiring changes to pass style checks.
> 
> 
> Diffs
> -----
> 
>   commons/src/main/java/org/apache/aurora/common/application/AppLauncher.java 80b24bd777e2bd1035a4b29a0a7865b7d7c207e7

>   commons/src/main/java/org/apache/aurora/common/zookeeper/guice/client/ZooKeeperClientModule.java
b44e09eb964def64649e7a30357567109f9946a3 
>   commons/src/main/java/org/apache/aurora/common/zookeeper/guice/client/flagged/FlaggedClientConfig.java
f3e3a84a389e0ce7fda5ba11fc26e4548c087dae 
>   commons/src/main/java/org/apache/aurora/common/zookeeper/testing/BaseZooKeeperTest.java
d97c00167b7b875f710b4cce51de5b4c95e39e23 
>   commons/src/main/java/org/apache/aurora/common/zookeeper/testing/ZooKeeperTestServer.java
afd2315cffca08ee0c029ef848e797e1eed3fcc9 
>   config/legacy_untested_classes.txt 346b947ed30c6e585428b72a457c4778978829ca 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java bf8ab3102aacb3b981cf09ee65a9f2e8f57635c6

>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 89399f1ef1096de17cc3a20370551cbda37d773e

>   src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLogStreamModule.java e47dbaa8b0654a6f5b23ef794162012be3dc6c37

>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 7f141df03336504127b4ad7822efad3da0c8c9a7

> 
> Diff: https://reviews.apache.org/r/38315/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message