aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zameer Manji" <zma...@apache.org>
Subject Re: Review Request 38302: Replace incorrect/misleading use of constraints with best practices doc.
Date Fri, 11 Sep 2015 17:56:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38302/#review98648
-----------------------------------------------------------

Ship it!


Ship It!

- Zameer Manji


On Sept. 11, 2015, 8:46 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38302/
> -----------------------------------------------------------
> 
> (Updated Sept. 11, 2015, 8:46 a.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> There are a few related changes here:
> - removed a doc entry that is false circa 0.8.0
> - removed host limit constraints from vagrant slave and tasks.  these are somewhat misleading
to people because i have observed several folks copying them and thinking they're still required
> 
> 
> Diffs
> -----
> 
>   docs/deploying-aurora-scheduler.md 73f7b191d433adecf9e94b1faedb170e1fea9c8b 
>   examples/vagrant/upstart/mesos-slave.conf 9af680e25ae6b52ebb292853831c5c009f666b19

>   src/test/sh/org/apache/aurora/e2e/http/http_example.aurora d7bf10807f186e043ab9f7cf7b78c3e4d5ee9d90

>   src/test/sh/org/apache/aurora/e2e/http/http_example_updated.aurora c97396620eb71ee644df991d3227db240cddc741

> 
> Diff: https://reviews.apache.org/r/38302/diff/
> 
> 
> Testing
> -------
> 
> Doc rendered here: https://github.com/wfarner/aurora/blob/wfarner/constraints_best_practices/docs/deploying-aurora-scheduler.md#best-practices
> 
> Successfully ran end-to-end tests to validate other changes.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message