aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stephan Erb" <step...@dev.static-void.de>
Subject Re: Review Request 38270: Remove redundancy between breadcrumbs and page headers. Also make job dashboard link more prominent.
Date Fri, 11 Sep 2015 14:34:14 GMT


> On Sept. 11, 2015, 9:55 a.m., Stephan Erb wrote:
> > src/main/resources/scheduler/assets/breadcrumb.html, line 35
> > <https://reviews.apache.org/r/38270/diff/2/?file=1067960#file1067960line35>
> >
> >     The title is rather specific and might not match what people outside of Twitter
use the job_viz_url for.
> >     
> >     Besides that: Awesome improvement!
> 
> Joshua Cohen wrote:
>     Do you think naming it based on the Scheduler command line arg would be better? I.e.
just call it "Stats"?
> 
> Stephan Erb wrote:
>     Good question. I guess stats are just one thing that could be shown on the Dashboard.
What about "External dashboard of this job"?
> 
> Joshua Cohen wrote:
>     That's a little bit verbose for my tastes (and why I originally shortened it to just
"Dashboard") ;). Using an icon for this link left it open to interpretation which was both
good (you could infer whatever meaning you want) and bad (no one knew what the icon represented
on its own). I'm just going to leave it as Dashboard for now, if you feel strongly about finding
a different name, please file a ticket?

I was talking about the tooltip not about the link name. But I have no strong opinion here.
Go ahead :-)


- Stephan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38270/#review98577
-----------------------------------------------------------


On Sept. 11, 2015, 4:23 a.m., Joshua Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38270/
> -----------------------------------------------------------
> 
> (Updated Sept. 11, 2015, 4:23 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Bill Farner.
> 
> 
> Bugs: AURORA-1474 and AURORA-783
>     https://issues.apache.org/jira/browse/AURORA-1474
>     https://issues.apache.org/jira/browse/AURORA-783
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Remove redundancy between breadcrumbs and page headers. Also make job dashboard link
more prominent.
> 
> 
> Diffs
> -----
> 
>   examples/vagrant/upstart/aurora-scheduler.conf f710295349c081ec9440bf5668a6e075a863b6c1

>   src/main/resources/scheduler/assets/breadcrumb.html 9265277b4a9347db28aaa9c367f259af4876d8ac

>   src/main/resources/scheduler/assets/css/app.css faa387b98a12ea6dcdb8d19b91af95b07302eda9

>   src/main/resources/scheduler/assets/home.html fadf00d81b8f9b62597cca24396b27c42fb9c89b

>   src/main/resources/scheduler/assets/instance.html 317e2ce3f236ec58d57289217034c79ac543a3fe

>   src/main/resources/scheduler/assets/job.html a8be604b27620e2bb3fca1254de9dc66f6bae111

>   src/main/resources/scheduler/assets/js/controllers.js 9ac62c86e096fb7cd27cb87bd1f7fc413cb5613a

>   src/main/resources/scheduler/assets/js/services.js dbad59b79a4b08d8b022419eeb89053f6c36d1ea

>   src/main/resources/scheduler/assets/role.html 3072ae34421624f9615acbc56eb5b3ae2a20bac0

> 
> Diff: https://reviews.apache.org/r/38270/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew jsHint
> 
> See attached screenshots.
> 
> 
> File Attachments
> ----------------
> 
> Home Page
>   https://reviews.apache.org/media/uploaded/files/2015/09/10/7ab3b0a2-82e5-4451-9d22-e3c2ee9c9674__Screen_Shot_2015-09-10_at_6.47.50_PM.png
> Role Page
>   https://reviews.apache.org/media/uploaded/files/2015/09/10/0b1035d9-8156-4889-a136-1b9fc5794ff7__Screen_Shot_2015-09-10_at_6.47.54_PM.png
> Job Page
>   https://reviews.apache.org/media/uploaded/files/2015/09/10/9c717720-0480-4fbb-9b44-ca027b1f1232__Screen_Shot_2015-09-10_at_6.47.57_PM.png
> Instance Page
>   https://reviews.apache.org/media/uploaded/files/2015/09/10/1ee53992-9347-4ced-8707-055880bee5b5__Screen_Shot_2015-09-10_at_6.48.03_PM.png
> Update Page
>   https://reviews.apache.org/media/uploaded/files/2015/09/10/9f85e4eb-28e9-4507-a217-6bd20953b1b8__Screen_Shot_2015-09-10_at_6.48.08_PM.png
> Environment Page
>   https://reviews.apache.org/media/uploaded/files/2015/09/10/85b7311d-2ad9-4769-8b49-9e1410d817fc__Screen_Shot_2015-09-10_at_6.50.53_PM.png
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message