aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aurora ReviewBot" <wfar...@apache.org>
Subject Re: Review Request 38111: Disable mimetype guessing in the observer chroot browser.
Date Thu, 03 Sep 2015 23:53:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38111/#review97697
-----------------------------------------------------------


Master (9c0b1b2) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Sept. 3, 2015, 10:15 p.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38111/
> -----------------------------------------------------------
> 
> (Updated Sept. 3, 2015, 10:15 p.m.)
> 
> 
> Review request for Aurora and Joshua Cohen.
> 
> 
> Bugs: AURORA-1479
>     https://issues.apache.org/jira/browse/AURORA-1479
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This disables the mimetype guessing of files served by the chroot browser and sets it
to the standard `application/octet-stream` mimetype. This prevents browsers from trying to
decompress gzipped files or other surprising behaviour for users.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/thermos/observer/http/file_browser.py 1750f5bd0937f8ce411f976db488bf5d14930577

> 
> Diff: https://reviews.apache.org/r/38111/diff/
> 
> 
> Testing
> -------
> 
> ./pants test src/test/python/apache/thermos/observer::
> Manual inspection of Content-Type header via vagrant.
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message