aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suman Karumuri" <ma...@apache.org>
Subject Re: Review Request 38081: Dropping quota check for dedicated jobs and exposing dedicated consumption.
Date Thu, 03 Sep 2015 01:27:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38081/#review97593
-----------------------------------------------------------



api/src/main/thrift/org/apache/aurora/gen/api.thrift (line 369)
<https://reviews.apache.org/r/38081/#comment153607>

    I think it will be better if we split this into nonProdSharedConsumption and nonProdDedicatedConsumption.



src/main/resources/scheduler/assets/js/controllers.js (line 161)
<https://reviews.apache.org/r/38081/#comment153609>

    I think we should see if the role has jobs running on dedicated boxes. If it does, show
nonProdDedicatedConsumption and prodDedicatedConsumption else hide it.
    
    If we expose prod and non prod dedicated consumption, we also have to rename the current
quota titles to Production shared consumption or something similar. 
    
    I prefer not exposing the dedicated aspect to jobs running in shared pool since users
may take it as an encouagement to run on dedicated boxes. For jobs running in shared pool,
we don't have to change the terminology.
    
    It may be simpler to just implement as 2 different tables one for shared pool jobs and
one for jobs involving mixed workloads.


- Suman Karumuri


On Sept. 3, 2015, 12:46 a.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38081/
> -----------------------------------------------------------
> 
> (Updated Sept. 3, 2015, 12:46 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Bill Farner, and Zameer Manji.
> 
> 
> Bugs: AURORA-1460
>     https://issues.apache.org/jira/browse/AURORA-1460
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This change drops quota enforcement for dedicated jobs and adds dedicated resource consumption
into the thrift API. Feel free to pushback on the latter but I think users will find it immediately
confusing when we change the "Prod consumption" to something like "Prod shared pool consumption"
in the UI/client and not provide the missing dedicated rollup numbers.
> 
> 
> Diffs
> -----
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 21137bbbdc3010c6b1e2cc0ebb3b99bfa8490563

>   src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java b40ecd0af7c1d1bb9372bd89c741622ce4c9040c

>   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 8787aeaa6655cfab1e0a6d5719f9e08a89df7631

>   src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 3d89e43659750de63d7588f8574e7a350caea04b

>   src/main/python/apache/aurora/client/api/quota_check.py 75406ac1d3ec9ba655daf7c6125f208f74290cfb

>   src/main/python/apache/aurora/client/cli/quota.py e8aa010f5ecce0464a8ad6b072bccba589fe16d7

>   src/main/resources/scheduler/assets/js/controllers.js 98920196db34f2eb4dcad93429274517e7383efe

>   src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java db60cd21d06d636505202bac7277a13dc24d46e6

>   src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java 4d4e752088f7dca99675cc66782ae046bbd516d6

>   src/test/python/apache/aurora/admin/test_admin.py d793293acc7f77c0081968334c38b984d865fbc8

>   src/test/python/apache/aurora/client/api/test_quota_check.py 6c9bc373d1868bd6e0cae2f2218261f39fd7ab8f

>   src/test/python/apache/aurora/client/cli/test_quota.py 3573e4c4575577e2232d2b99ca781b06a03d48d7

> 
> Diff: https://reviews.apache.org/r/38081/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message