aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 37926: Adding oversubscription e2e tests.
Date Wed, 02 Sep 2015 02:32:57 GMT


> On Aug. 31, 2015, 4:31 p.m., Bill Farner wrote:
> > examples/vagrant/upstart/mesos-slave.conf, line 38
> > <https://reviews.apache.org/r/37926/diff/3/?file=1060746#file1060746line38>
> >
> >     any reason for the verbosity?  Why not just 'fixed_estimator' or something equally
brief?
> 
> Maxim Khutornenko wrote:
>     This is how Mesos defines it: https://github.com/apache/mesos/blob/a0811310c82ee25644fc9a6362313ce3619e46d9/src/slave/resource_estimators/fixed.cpp

Oh wow, that's interesting.


> On Aug. 31, 2015, 4:31 p.m., Bill Farner wrote:
> > src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh, line 322
> > <https://reviews.apache.org/r/37926/diff/3/?file=1060752#file1060752line322>
> >
> >     We probably only want to create a job using revocable resources and watch that
it doesn't explode.  The full extra round of test cases seems excessive.
> 
> Maxim Khutornenko wrote:
>     I started that route but then quickly realized I wanted observer tests, make sure
update works and etc. Seems like too much customization for no apparent benefit. Are you concerned
about the overall execution speed?

Yeah, i'm worried about execution speed if we're concerned about covering this full set of
behavior for arbitrary features.  For example, i'm not convinced that job updates need to
be exercised for this case (or checking that the oberver doesn't 404, for that matter).  I
would much rather see feature-related test cases be as feature-specific as possible.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37926/#review97195
-----------------------------------------------------------


On Sept. 1, 2015, 10:15 a.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37926/
> -----------------------------------------------------------
> 
> (Updated Sept. 1, 2015, 10:15 a.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Also, had to backout client tier validation added earlier until the feature exits beta.
> 
> 
> Diffs
> -----
> 
>   examples/vagrant/upstart/aurora-scheduler.conf e909451892f117e9e6eb80994079661827a0914c

>   examples/vagrant/upstart/mesos-slave.conf 2b6a60673fc0a7ea3b73471701cd5d3efd6ce639

>   src/main/java/org/apache/aurora/scheduler/http/Offers.java 4329ce10189df41a7a45cd6cc369333d7d5f65b0

>   src/main/python/apache/aurora/client/config.py f5ac084ae5b448221363add9476334742b217b92

>   src/test/python/apache/aurora/client/test_config.py 37459f5218e76fac831601806a0331927c0ee2c0

>   src/test/sh/org/apache/aurora/e2e/http/http_example.aurora c1a10d8ea60be6aa56e4517fb34288d7d5ae1480

>   src/test/sh/org/apache/aurora/e2e/http/http_example_docker.aurora 870b3e68035fdf86253cf9b92b606645134b3369

>   src/test/sh/org/apache/aurora/e2e/http/http_example_docker_updated.aurora e55aad3a58d4e3c19332e06b70771f51f07aa9b7

>   src/test/sh/org/apache/aurora/e2e/http/http_example_updated.aurora 423dd4d4e8b03c2f852e25acd9340bd6288b7d24

>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 018efbe43de0c829799bc2f789958c55b1cb61a4

> 
> Diff: https://reviews.apache.org/r/37926/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message