aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 38010: Stop in-progress instances from pulsing when update has been aborted.
Date Wed, 02 Sep 2015 02:30:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38010/#review97384
-----------------------------------------------------------

Ship it!


Ship It!

- Bill Farner


On Sept. 1, 2015, 10:29 a.m., Joshua Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38010/
> -----------------------------------------------------------
> 
> (Updated Sept. 1, 2015, 10:29 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Stop in-progress instances from pulsing when update has been aborted.
> 
> Also removed the "INSTANCE-" prefix from tooltip as it seemed superfluous and added "ABORTED"
to the tooltip for instances that were "UPDATING" when the update was aborted. An argument
can be made for adding "ABORTED" to the tooltip for all non-terminal states (PENDING, etc.),
let me know if you think we should add it for those as well.
> 
> 
> Diffs
> -----
> 
>   src/main/resources/scheduler/assets/css/app.css 9437c53e695d1c4009d9df5fb23e34479f5b3d2d

>   src/main/resources/scheduler/assets/js/directives.js d8f722c441b9399e7eacd6ae29966b3fb24a422d

>   src/main/resources/scheduler/assets/update.html c8867093338593e5561e42fdee7cc5f15be0356e

> 
> Diff: https://reviews.apache.org/r/38010/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew jshint
> 
> Verified the pulsing stops for an aborted update. Also see screenshot for tooltip changes.
> 
> 
> File Attachments
> ----------------
> 
> Screen Shot 2015-09-01 at 12.08.51 PM.png
>   https://reviews.apache.org/media/uploaded/files/2015/09/01/340c71be-564f-4024-8ee3-bab960edfad0__Screen_Shot_2015-09-01_at_12.08.51_PM.png
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message