Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 174BB18843 for ; Sun, 30 Aug 2015 21:34:23 +0000 (UTC) Received: (qmail 60595 invoked by uid 500); 30 Aug 2015 21:34:22 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 60543 invoked by uid 500); 30 Aug 2015 21:34:22 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 60522 invoked by uid 99); 30 Aug 2015 21:34:22 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 30 Aug 2015 21:34:22 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 4AFC11D550D; Sun, 30 Aug 2015 21:34:21 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6790617046092588538==" MIME-Version: 1.0 Subject: Re: Review Request 37874: Remove unused code from commons fork. From: "Bill Farner" To: "Zameer Manji" Cc: "Bill Farner" , "Aurora" Date: Sun, 30 Aug 2015 21:34:21 -0000 Message-ID: <20150830213421.16295.88585@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Bill Farner" X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/37874/ X-Sender: "Bill Farner" References: <20150830175353.16295.49038@reviews.apache.org> In-Reply-To: <20150830175353.16295.49038@reviews.apache.org> Reply-To: "Bill Farner" X-ReviewRequest-Repository: aurora --===============6790617046092588538== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Aug. 30, 2015, 10:53 a.m., Zameer Manji wrote: > > commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSetImpl.java, line 599 > > > > > > Please update (or delete) the JavaDoc here. Thanks, fixed. - Bill ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37874/#review97034 ----------------------------------------------------------- On Aug. 28, 2015, 6:51 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37874/ > ----------------------------------------------------------- > > (Updated Aug. 28, 2015, 6:51 p.m.) > > > Review request for Aurora and Zameer Manji. > > > Repository: aurora > > > Description > ------- > > Carrying on from https://reviews.apache.org/r/37872/, this patch goes a bit deeper and starts pulling out some unused functions and behavior, which in turn allows for a bunch of additional deletion. > > > Diffs > ----- > > commons/src/main/java/org/apache/aurora/common/application/modules/LocalServiceRegistry.java 027e4a7114b4c776a86c31aed1033c45e8e20a02 > commons/src/main/java/org/apache/aurora/common/base/Closures.java d741e9c54dc4d1006ec2d39235307a5e61edb807 > commons/src/main/java/org/apache/aurora/common/base/Commands.java 6d9fc4c321b602149ede49daa6ba16c8d83a3748 > commons/src/main/java/org/apache/aurora/common/base/MorePreconditions.java 1fe19d4eb0aeae1626434d9962aae993d1c66527 > commons/src/main/java/org/apache/aurora/common/collections/Multimaps.java 7f94a8a595fbff0c1b2e7f4089a9f535120d358a > commons/src/main/java/org/apache/aurora/common/inject/Bindings.java f910f22eab01db30bac139fc40a944f3d2bab7fd > commons/src/main/java/org/apache/aurora/common/io/CompatibilityCodec.java c49c7dd67f1ead75f23251c2bc5849c952289a3d > commons/src/main/java/org/apache/aurora/common/io/ThriftCodec.java 66447880e133aba614ef4b9fb2b48313a308d465 > commons/src/main/java/org/apache/aurora/common/net/Environment.java 65fd15ec6ebd6b9063789dd16be17a03f383140e > commons/src/main/java/org/apache/aurora/common/stats/Stats.java 2191f77924ab00db978a2ffeb1286d415f761355 > commons/src/main/java/org/apache/aurora/common/stats/StatsProvider.java cb1c56bc96d61a2863f1addeed111ba611c5df2e > commons/src/main/java/org/apache/aurora/common/util/BackoffDecider.java e11a52c690db646472b9d48a1772e4b83f7ae906 > commons/src/main/java/org/apache/aurora/common/util/BackoffHelper.java 8f31ea789676db5abf3510154f05372d9b0c9541 > commons/src/main/java/org/apache/aurora/common/util/CommandExecutor.java e591721a2cac51d800a40b3b0e592594f75ac59f > commons/src/main/java/org/apache/aurora/common/util/Random.java a1f14968a0400729b4f7d9373b63e56d622f83ce > commons/src/main/java/org/apache/aurora/common/util/Stat.java 2fec9d991d779709f2419811457681f53cf15a37 > commons/src/main/java/org/apache/aurora/common/util/StateMachine.java 89046da4951cae8931cfc40b044331037ba11a1e > commons/src/main/java/org/apache/aurora/common/util/Timer.java 15602acec3c5716e3e152590693ddc075ae29c79 > commons/src/main/java/org/apache/aurora/common/zookeeper/CandidateImpl.java e16a64dda003c7d2c6aef932eeca07ed81f53500 > commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSetImpl.java 9a33d3eddbf73e4cb6dabbb8bb9e7c9867dd772e > commons/src/main/java/org/apache/aurora/common/zookeeper/SingletonService.java 660f3d6c636ce18902e256c064c2ed83bb18f4a4 > commons/src/main/java/org/apache/aurora/common/zookeeper/guice/ServerSetModule.java c8a3214ae7a0db4b61df35508f8ba6251848b221 > commons/src/main/java/org/apache/aurora/common/zookeeper/guice/client/ZooKeeperClientModule.java 08cdf550e0866076d0e66e2e6d656e96f9966e84 > commons/src/test/java/org/apache/aurora/common/application/modules/LifecycleModuleTest.java fdbef6f054999171c84f394cda2a89209bdd2429 > commons/src/test/java/org/apache/aurora/common/application/modules/LocalServiceRegistryTest.java a9fe793f6392140b05ede4663b22aa0361e00df0 > commons/src/test/java/org/apache/aurora/common/base/ClosuresTest.java d2c9565bbd6c58efdbec7cdce700c8af959b5dda > commons/src/test/java/org/apache/aurora/common/base/CommandsTest.java 0a9bad91d7b9135b8837e6ee357424a5a658162b > commons/src/test/java/org/apache/aurora/common/collections/Iterables2Test.java e74038d994d66286ad11e97fb67b98f3c6a56618 > commons/src/test/java/org/apache/aurora/common/inject/BindingsTest.java a84de3e83dd550f3681cdb2d0af87e94682d786f > commons/src/test/java/org/apache/aurora/common/io/CodecTestUtilities.java 4cfd4c997f37e5599b3ae39afe1b46d9f278ee5a > commons/src/test/java/org/apache/aurora/common/io/CompatibilityCodecTest.java 4c1b537bb5d08719917c2262705b0ab1fe5f3cdd > commons/src/test/java/org/apache/aurora/common/io/ThriftCodecTest.java ce112dc609621ef11709e5ce0fa7d762f3aa4745 > commons/src/test/java/org/apache/aurora/common/stats/StatsTest.java 7946a598cfc235e2218e5126ebaf0b1eac9d5d5a > commons/src/test/java/org/apache/aurora/common/util/BackoffDeciderTest.java 7831063e64309fc5f9d564275ba46ae359c21595 > commons/src/test/java/org/apache/aurora/common/util/StateMachineTest.java e10e019db6b72ecd0e787d2ae7e936bf3fc15dca > commons/src/test/java/org/apache/aurora/common/zookeeper/CandidateImplTest.java cf7e5a3b58574f7b9530d13ee390f8b3e5eeee7f > commons/src/test/java/org/apache/aurora/common/zookeeper/ServerSetImplTest.java 4db578cb12c740ce06b378d871cf2cce1c6a1ebe > commons/src/test/java/org/apache/aurora/common/zookeeper/ServerSetsTest.java e13b688eaf932b412f558c78798ee9fb9b8edbf0 > commons/src/test/java/org/apache/aurora/common/zookeeper/SingletonServiceTest.java 7f537ec4abfdbd25adb962bf78b8b8b62f185ebb > commons/src/test/java/org/apache/aurora/common/zookeeper/guice/ServerSetModuleTest.java a397dd920d8f4dd3408f47f1f449b1681f2a8215 > src/jmh/java/org/apache/aurora/benchmark/fakes/FakeStatsProvider.java 722531c82610579213035958cef6a4e021267862 > > Diff: https://reviews.apache.org/r/37874/diff/ > > > Testing > ------- > > Review bot won't like this one until the related patch lands. > > > Thanks, > > Bill Farner > > --===============6790617046092588538==--