Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 570D0107BC for ; Sat, 29 Aug 2015 18:54:52 +0000 (UTC) Received: (qmail 70372 invoked by uid 500); 29 Aug 2015 18:54:52 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 70324 invoked by uid 500); 29 Aug 2015 18:54:52 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 70295 invoked by uid 99); 29 Aug 2015 18:54:51 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 29 Aug 2015 18:54:51 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id D0B5D26D159; Sat, 29 Aug 2015 18:54:50 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0486735897176070692==" MIME-Version: 1.0 Subject: Re: Review Request 37825: Adding minimal implementation of the external tier config. From: "Aurora ReviewBot" To: "Bill Farner" , "Zameer Manji" Cc: "Aurora ReviewBot" , "Maxim Khutornenko" , "Aurora" Date: Sat, 29 Aug 2015 18:54:50 -0000 Message-ID: <20150829185450.13583.58204@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Aurora ReviewBot" X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/37825/ X-Sender: "Aurora ReviewBot" References: <20150829183419.13583.92752@reviews.apache.org> In-Reply-To: <20150829183419.13583.92752@reviews.apache.org> Reply-To: "Aurora ReviewBot" X-ReviewRequest-Repository: aurora --===============0486735897176070692== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37825/#review96997 ----------------------------------------------------------- Ship it! Master (782f883) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Aug. 29, 2015, 6:34 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37825/ > ----------------------------------------------------------- > > (Updated Aug. 29, 2015, 6:34 p.m.) > > > Review request for Aurora, Bill Farner and Zameer Manji. > > > Bugs: AURORA-1437 > https://issues.apache.org/jira/browse/AURORA-1437 > > > Repository: aurora > > > Description > ------- > > The external config file is optional for now as tiers are not fully defined yet. > > > Diffs > ----- > > examples/vagrant/upstart/aurora-scheduler-kerberos.conf 744b4a35c61e749734e222b3d4cbd296927665aa > examples/vagrant/upstart/aurora-scheduler.conf 789a3a0315e8530880999432aa9b1e7d0f57d1ff > src/jmh/java/org/apache/aurora/benchmark/Offers.java 26bad1cce987ef7f46368a5936cf056aeb2f63b1 > src/main/java/org/apache/aurora/scheduler/SchedulerModule.java d4bc6b9bb10c982fb6a2458d7fdd12bddbe98eca > src/main/java/org/apache/aurora/scheduler/TierInfo.java 61bf30a7f11d2d4b9e49c58a6ed9ecd779d7e5ba > src/main/java/org/apache/aurora/scheduler/TierManager.java 652afece17a7eb09b0ca68066707b1b8fbf024f0 > src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java d7f3c60d383cf10afb0c0fcf4fe29972b183458c > src/test/java/org/apache/aurora/scheduler/ResourceSlotTest.java 399f58de6196b97abd359ecef8131b63480d591a > src/test/java/org/apache/aurora/scheduler/ResourcesTest.java eb1baedcb13c2f169d819d137f22cb8b88db149c > src/test/java/org/apache/aurora/scheduler/SchedulerModuleTest.java PRE-CREATION > src/test/java/org/apache/aurora/scheduler/TierManagerTest.java eb0207114e1b93968cb65832f154a9cd3bc3232e > src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java adcc7a823ecf30442016ecbdd655622d6aeba65e > src/test/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilterTest.java 819b51e4c314749dc48db25693503af7d1ed0c54 > src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java d8a524d98771ee68d7b4d423fb34e28101a04d27 > src/test/resources/org/apache/aurora/scheduler/tiers-example.json PRE-CREATION > > Diff: https://reviews.apache.org/r/37825/diff/ > > > Testing > ------- > > ./gradlew -Pq build > ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > > > Thanks, > > Maxim Khutornenko > > --===============0486735897176070692==--