Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 461E4106F4 for ; Fri, 28 Aug 2015 05:06:44 +0000 (UTC) Received: (qmail 97352 invoked by uid 500); 28 Aug 2015 05:06:44 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 97297 invoked by uid 500); 28 Aug 2015 05:06:44 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 97274 invoked by uid 99); 28 Aug 2015 05:06:43 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 28 Aug 2015 05:06:43 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id AD2CA26C8C9; Fri, 28 Aug 2015 05:06:42 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1542252990354713404==" MIME-Version: 1.0 Subject: Re: Review Request 37872: Remove unused classes from commons fork. From: "Aurora ReviewBot" To: "Zameer Manji" Cc: "Bill Farner" , "Aurora ReviewBot" , "Aurora" Date: Fri, 28 Aug 2015 05:06:42 -0000 Message-ID: <20150828050642.13584.47420@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Aurora ReviewBot" X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/37872/ X-Sender: "Aurora ReviewBot" References: <20150828044643.13584.86379@reviews.apache.org> In-Reply-To: <20150828044643.13584.86379@reviews.apache.org> Reply-To: "Aurora ReviewBot" X-ReviewRequest-Repository: aurora --===============1542252990354713404== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37872/#review96834 ----------------------------------------------------------- Ship it! Master (06ddaad) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Aug. 28, 2015, 4:46 a.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37872/ > ----------------------------------------------------------- > > (Updated Aug. 28, 2015, 4:46 a.m.) > > > Review request for Aurora and Zameer Manji. > > > Repository: aurora > > > Description > ------- > > Starting with low-hanging fruit - remove (almost exclusively) classes that are unused. > > > Diffs > ----- > > commons/src/main/java/org/apache/aurora/common/application/http/DefaultQuitHandler.java 6a48b84b3a04671498c012ecb7a31ace512b5394 > commons/src/main/java/org/apache/aurora/common/application/http/GraphViewer.java f786f9e028ce049cd55bf95bba86057e7abbaccb > commons/src/main/java/org/apache/aurora/common/application/http/HttpAssetConfig.java e2160e7d5c9db18bd2377ddabc03608e5143a72a > commons/src/main/java/org/apache/aurora/common/application/http/HttpFilterConfig.java d09631757a942f15337836fdea8fff30ec735233 > commons/src/main/java/org/apache/aurora/common/application/http/HttpServletConfig.java 4444e4c58a21c1fdb2f12ce67efaaa888c33b48c > commons/src/main/java/org/apache/aurora/common/application/http/Registration.java b66c8c8878001953422f9799cdd4545bdd931c51 > commons/src/main/java/org/apache/aurora/common/application/modules/LifecycleModule.java b3e59e78b3f863cb352289ab2d3411c914d33264 > commons/src/main/java/org/apache/aurora/common/application/modules/LogModule.java 107e3aa51c7cf3729bb56800adece05742c55d30 > commons/src/main/java/org/apache/aurora/common/application/modules/StatsExportModule.java ba93d4c8f4707bd6ccb13e108216483625240698 > commons/src/main/java/org/apache/aurora/common/application/modules/ThriftModule.java 55236dfc53f4f842bc34b6d66d9fceeab39e4433 > commons/src/main/java/org/apache/aurora/common/base/CachingSupplier.java 3a1511dc8bf3651ccd91157db5716321485dfa5b > commons/src/main/java/org/apache/aurora/common/base/CallableExceptionalSupplier.java b4f2d53293552164613119426993c5ae94558f1f > commons/src/main/java/org/apache/aurora/common/base/Either.java a746e72a95fee6e6108dbf0eead960f6a2227216 > commons/src/main/java/org/apache/aurora/common/base/ExceptionTransporter.java e5cb60dc6ba672e7936caaee38c9e9e728bbe6d3 > commons/src/main/java/org/apache/aurora/common/base/ExceptionalFunctions.java f06c66cd027147903ea18ede9490c4c5c6ce122f > commons/src/main/java/org/apache/aurora/common/base/SupplierE.java ecad43e08e399db5b70b9f6b5fcdb401725b4efc > commons/src/main/java/org/apache/aurora/common/collections/Bits.java f07e04a08f3a1a1ce43c0cea3ea55e22960bbfa2 > commons/src/main/java/org/apache/aurora/common/common/webassets/bootstrap/BootstrapModule.java 9cb6f547dfa470808def5d088984636a58dbf93c > commons/src/main/java/org/apache/aurora/common/common/webassets/jquery/JQueryModule.java a8e4524e6b93eaf697a5986cf66ebc8c38a0f2c2 > commons/src/main/java/org/apache/aurora/common/inject/DefaultProvider.java 38fbe4dc692b51595499b392dcfb75af4b3edc44 > commons/src/main/java/org/apache/aurora/common/inject/ProviderMethodModule.java 7543ff1dedc55897d7ec45d35be74caf42e74a56 > commons/src/main/java/org/apache/aurora/common/io/Base64ZlibCodec.java ed36e2a0e5e4ff36de10434f7bbd65c2155f4f40 > commons/src/main/java/org/apache/aurora/common/io/JsonCodec.java 1b955dbaccedebb644c7c57e0fc94dbff14e08c3 > commons/src/main/java/org/apache/aurora/common/io/Streamer.java 902676036f1e50da7bd794ea23704bf6c5dc26c5 > commons/src/main/java/org/apache/aurora/common/logging/BufferedLog.java a83895df65a399c1a85e421254d5e1ec167f4521 > commons/src/main/java/org/apache/aurora/common/logging/LogUtil.java 5f97cb2684d136a30f77b2e6d3f8aa5ee3a0163d > commons/src/main/java/org/apache/aurora/common/logging/julbridge/JULBridgeHandler.java 8a9e18e09e2184301af1c79f3027a380731451a3 > commons/src/main/java/org/apache/aurora/common/logging/julbridge/JULBridgeLevelConverter.java 14bbd4cbb7cfeec6889f282c3fcb40dde008b600 > commons/src/main/java/org/apache/aurora/common/logging/julbridge/JULBridgeLogManager.java adf1a83d4086fb0dce12cbd06df8e7c2898fbeb3 > commons/src/main/java/org/apache/aurora/common/net/ProxyAuthorizer.java c5126dc4580d6e15222533071ec64bce529c8782 > commons/src/main/java/org/apache/aurora/common/net/ProxyConfig.java fa474b5b3ef2a0e3e1e9c74ad4d6990ba65073b2 > commons/src/main/java/org/apache/aurora/common/net/UrlHelper.java 3f06d6335074119fa4a3dd3e364eaa9e69396b03 > commons/src/main/java/org/apache/aurora/common/net/UrlResolver.java 96c5f072b62ba74f3a96239a0069180f720bc200 > commons/src/main/java/org/apache/aurora/common/net/UrlResolverUtil.java 4b95bb7655cb86a6001b346df7bc66619b276ac8 > commons/src/main/java/org/apache/aurora/common/net/UrlTokenizerUtil.java 67798a3203e24b88da2403393a042fbd1d3df0ba > commons/src/main/java/org/apache/aurora/common/net/http/GuiceServletConfig.java e4fa8aa97da67a697867db88cb6fe3af4b00b115 > commons/src/main/java/org/apache/aurora/common/net/http/HttpServerDispatch.java 3208267ba53986dc94402eb834571d65fd1ba293 > commons/src/main/java/org/apache/aurora/common/net/http/JettyHttpServerDispatch.java a3fa57e32fb30e5cbe7a3785419e60a956bd0e28 > commons/src/main/java/org/apache/aurora/common/net/http/RequestLogger.java 86778808d3e1c151a9fbb039a7c2379548923f80 > commons/src/main/java/org/apache/aurora/common/net/http/filters/AbstractHttpFilter.java 681a95d3a7169b2db2d0dc15c69535e8a34ff66d > commons/src/main/java/org/apache/aurora/common/net/http/filters/HttpStatsFilter.java 493018a5a307b80ec74b08e3f9fb67630470095a > commons/src/main/java/org/apache/aurora/common/net/http/handlers/ThriftServlet.java 540ab694afd20c81b0297cd071425583227006d4 > commons/src/main/java/org/apache/aurora/common/net/loadbalancing/LeastConnectedStrategy.java e0beb25ce7735c4efe862bf559f58e90d45c6066 > commons/src/main/java/org/apache/aurora/common/net/loadbalancing/LoadBalancer.java b15137db8a11556dc55c39fb2d019678f0423cec > commons/src/main/java/org/apache/aurora/common/net/loadbalancing/LoadBalancerImpl.java 30e77c921847135cf6b62cba49bcb1cf291cfd8d > commons/src/main/java/org/apache/aurora/common/net/loadbalancing/LoadBalancingStrategy.java 7f334160ac11d55d14cc6473e705a4a729069d10 > commons/src/main/java/org/apache/aurora/common/net/loadbalancing/MarkDeadStrategy.java 05a405650879ad46175739b99b1b767e385cfe89 > commons/src/main/java/org/apache/aurora/common/net/loadbalancing/MarkDeadStrategyWithHostCheck.java 8170167b0cf2d6f40b47a35e0f984288c5597794 > commons/src/main/java/org/apache/aurora/common/net/loadbalancing/RandomStrategy.java a8da98065b72cb97df004dd8bd1f39ecf4435f52 > commons/src/main/java/org/apache/aurora/common/net/loadbalancing/RequestTracker.java 745e2f8b9d37c6f52d4b3f1c64e12f2c59a0e07f > commons/src/main/java/org/apache/aurora/common/net/loadbalancing/RoundRobinStrategy.java 56783319b3786635f58b76ce0a9f0af89db4ea97 > commons/src/main/java/org/apache/aurora/common/net/loadbalancing/StaticLoadBalancingStrategy.java b333b447601b9f6e4d73a7a95e2fe2a6904a9454 > commons/src/main/java/org/apache/aurora/common/net/loadbalancing/SubsetStrategy.java 0b852cfc16e203a494b55c4b1a40800f48376ade > commons/src/main/java/org/apache/aurora/common/net/loadbalancing/TrafficMonitorAdapter.java e0c5c3586cf4dc878ec7805fb7fa32005a944561 > commons/src/main/java/org/apache/aurora/common/net/monitoring/ConnectionMonitor.java 4d32a715692de3025919b08193cfcb37b804aa82 > commons/src/main/java/org/apache/aurora/common/net/monitoring/TrafficMonitor.java fba1e4bad237edd58033885320a7e6587ca728db > commons/src/main/java/org/apache/aurora/common/net/pool/ConnectionFactory.java cdaaeab95b5511c2487b05d831e75a104737cda7 > commons/src/main/java/org/apache/aurora/common/net/pool/ConnectionPool.java 316bf2bc139a6d2db5a4fa1eefb1f595bf6cbb44 > commons/src/main/java/org/apache/aurora/common/net/pool/DynamicHostSetUtil.java 4f7589392062028d382f49f872eb454d79b54da1 > commons/src/main/java/org/apache/aurora/common/net/pool/DynamicPool.java 2fd6046350216b2393f24ff58d346329ec76ea7e > commons/src/main/java/org/apache/aurora/common/net/pool/MetaPool.java df1bd962c63a67ad3ba61e3656ccaf8351c601d9 > commons/src/main/java/org/apache/aurora/common/net/pool/ObjectPool.java a665903f20f236757a1ca378c4e79319eaec7df2 > commons/src/main/java/org/apache/aurora/common/net/pool/ResourceExhaustedException.java fd48ddbda83f124c9bcbbfc81e697567edcdb87f > commons/src/main/java/org/apache/aurora/common/objectsize/ObjectSizeCalculator.java 95c88688a092d453417088dd42598d64030d2e44 > commons/src/main/java/org/apache/aurora/common/stats/ApproximateHistogram.java cfbf04e06579be7fbd48d4fd6ab54e9e89c2b79c > commons/src/main/java/org/apache/aurora/common/stats/CounterMap.java 024e67ba6021855f71d480dc72b0cc1e1aaea9aa > commons/src/main/java/org/apache/aurora/common/stats/CounterMapWithTopKey.java 1e90e85de0501b2c068e0a8bee87d993c1dc5c4d > commons/src/main/java/org/apache/aurora/common/stats/Elapsed.java 859ca7e884843908f1b8f74261ffad3336aac004 > commons/src/main/java/org/apache/aurora/common/stats/Entropy.java 4e011c152c50f3724113c46d2d12761b4ccbac64 > commons/src/main/java/org/apache/aurora/common/stats/Histogram.java 53c976d8ccec837571605ed874c6d004907835f9 > commons/src/main/java/org/apache/aurora/common/stats/Histograms.java 6818b055fa29c9a2f578dbc67e1c25b051e6a0cf > commons/src/main/java/org/apache/aurora/common/stats/MovingAverage.java 339737b70c493386d08eeb9305b7c305c2f34d2b > commons/src/main/java/org/apache/aurora/common/stats/MovingWindowDelta.java a20eed0533c8e545086d00c6100ebc6aba54403d > commons/src/main/java/org/apache/aurora/common/stats/NumericStatExporter.java 7345edc2c6fd7dcf59c600ea6a622db5aadf3136 > commons/src/main/java/org/apache/aurora/common/stats/PipelineStats.java 014a56a0fe1b4032a07ac199a350afcf91978123 > commons/src/main/java/org/apache/aurora/common/stats/Precision.java 7000e2f034ca5d2f5a791dc9d944e4203c3f73d8 > commons/src/main/java/org/apache/aurora/common/stats/PrintableHistogram.java a5874578daaa4a9ff3870047f7b55f545a2662d0 > commons/src/main/java/org/apache/aurora/common/stats/ReservoirSampler.java 79e7e04c839f7858242e58b6f8901f94e6dea8df > commons/src/main/java/org/apache/aurora/common/stats/Significance.java ff040e9d6a92658469d39dedae33fe8d4ee691f6 > commons/src/main/java/org/apache/aurora/common/stats/Statistics.java 498abb04f1f297b79f4c3ea218227e84ee9dc351 > commons/src/main/java/org/apache/aurora/common/stats/StatisticsInterface.java 893c069070456d5315a3a22f64ba3869be74984c > commons/src/main/java/org/apache/aurora/common/stats/Windowed.java 12ab468087acc0e201239f70c69c9540e126f310 > commons/src/main/java/org/apache/aurora/common/stats/WindowedApproxHistogram.java 6461a2e26ce896a73eabc2ef05f872107ebac55f > commons/src/main/java/org/apache/aurora/common/stats/WindowedHistogram.java 23e2f4f5703174e00d9d0f1ac9a16112565e6f65 > commons/src/main/java/org/apache/aurora/common/stats/WindowedStatistics.java ded3fafcbddbdd2bcf545611da4796077008dc01 > commons/src/main/java/org/apache/aurora/common/stats/testing/RealHistogram.java 36b11748188f97872178ed78132289b4a6c699d9 > commons/src/main/java/org/apache/aurora/common/testing/TearDownRegistry.java 02db0753924518d08f54abe47e98786a1d168ef7 > commons/src/main/java/org/apache/aurora/common/testing/mockito/MockitoTest.java cef57cc13996ba4db207ef8aa56d89c6e04a33c3 > commons/src/main/java/org/apache/aurora/common/thrift/Config.java 7ab122be16d516ef57c8a4c3547f63065ab09c15 > commons/src/main/java/org/apache/aurora/common/thrift/TResourceExhaustedException.java 54e2bd34bca0ae9949635b59727fb1be59aec50d > commons/src/main/java/org/apache/aurora/common/thrift/TTimeoutException.java 068abeab632653dbdf4b25ca24a0be34d6d4fa43 > commons/src/main/java/org/apache/aurora/common/thrift/TTransportConnection.java 5e5df6df7dc8109071e5651dffd1c4f73e7a0d45 > commons/src/main/java/org/apache/aurora/common/thrift/Thrift.java b36b46e13bafcb41fe20c15c76c2867bd7b90318 > commons/src/main/java/org/apache/aurora/common/thrift/ThriftConnectionFactory.java 8c302d3d66d4b15337fc77bc5b016b5567c90f23 > commons/src/main/java/org/apache/aurora/common/thrift/ThriftException.java 27e9f5e47647948ef43f433b9f39eb22d7361930 > commons/src/main/java/org/apache/aurora/common/thrift/ThriftFactory.java 75c58e2cd089eb207fd5506a96a8f6e3c13aa927 > commons/src/main/java/org/apache/aurora/common/thrift/callers/Caller.java 0200c492e838e0dcfc48aa60cf598c96da116f3d > commons/src/main/java/org/apache/aurora/common/thrift/callers/CallerDecorator.java bd0a952d95c2175e28e3db1e86476607878c055d > commons/src/main/java/org/apache/aurora/common/thrift/callers/DeadlineCaller.java 75ed1ec460e33f6170435e96c381620438b69e94 > commons/src/main/java/org/apache/aurora/common/thrift/callers/DebugCaller.java aff4006aea05096e06ed8d89059f5dd82df9f1dd > commons/src/main/java/org/apache/aurora/common/thrift/callers/RetryingCaller.java 84a0f4e03142e6050577175673e7140b64853888 > commons/src/main/java/org/apache/aurora/common/thrift/callers/StatTrackingCaller.java 514e665b20ed15c94f46ede332ad25210512d3a8 > commons/src/main/java/org/apache/aurora/common/thrift/callers/ThriftCaller.java 4e62940e3a1318bff3c8f73dc964b0247caebef1 > commons/src/main/java/org/apache/aurora/common/thrift/monitoring/TMonitoredNonblockingServerSocket.java a14f53a4a3589250cd03936f85c0ec75712f650e > commons/src/main/java/org/apache/aurora/common/thrift/monitoring/TMonitoredProcessor.java a0d7d5fd4d313a0c64b924acf700448915312825 > commons/src/main/java/org/apache/aurora/common/thrift/monitoring/TMonitoredServerSocket.java f4405c4fee27a23db755d04c0132fa85ff05ee67 > commons/src/main/java/org/apache/aurora/common/thrift/testing/MockTSocket.java 2cec7113ee81aa2415d05c93f8ee2b46604d53a3 > commons/src/main/java/org/apache/aurora/common/thrift/testing/TestThriftTypes.java 377228feea754c14f4478ca509b020c58cbd35ec > commons/src/main/java/org/apache/aurora/common/util/DateUtils.java eb209256384e08b4d75c01ce3bdec8676608a781 > commons/src/main/java/org/apache/aurora/common/util/FileUtils.java 9b23ee0fd04800c31d56c5376118f824b4f18dcb > commons/src/main/java/org/apache/aurora/common/util/LowResClock.java 69fb9edccf53d2fd12addc826667d4f04840673a > commons/src/main/java/org/apache/aurora/common/util/ParsingUtil.java 0747e7a8a5872c2109eacc123ecb1c3413df01df > commons/src/main/java/org/apache/aurora/common/util/QueueDrainer.java 243cf33a6cd28c44076e9d849de57e5fb00663b3 > commons/src/main/java/org/apache/aurora/common/util/RangeNormalizer.java 3e4de30c7d67ddffe45889c3f74d877f6760b64b > commons/src/main/java/org/apache/aurora/common/util/RateLimitedCommandExecutor.java 05b3c5f8916e44400eb1f6c40524d05c6470b2ec > commons/src/main/java/org/apache/aurora/common/util/RetryingRunnable.java 2f66d1373cfd82cd1b055c26a7caed9c8bba6937 > commons/src/main/java/org/apache/aurora/common/util/caching/Cache.java 72605ed25789038c443908c2a5d21e2ce08ea7d6 > commons/src/main/java/org/apache/aurora/common/util/caching/CachingMethodProxy.java 96a537729744771035fab26e6ee82617127824ae > commons/src/main/java/org/apache/aurora/common/util/caching/LRUCache.java 65639e3bfa9cab416e76a9c12159409683b4bb08 > commons/src/main/java/org/apache/aurora/common/util/concurrent/BackingOffFutureTask.java 2f963cfce5221b4ca0d1e452b24d830b78a90b0f > commons/src/main/java/org/apache/aurora/common/util/concurrent/RetryingFutureTask.java 7448dc1173cafe936ed83e79c8f70feeaa1b733a > commons/src/main/java/org/apache/aurora/common/util/logging/ResourceLoggingConfigurator.java 927fb2be1495fc88c5f0c0f02057f1b986c2dcaf > commons/src/main/java/org/apache/aurora/common/util/logging/UnresettableLogManager.java 66bbb378bc6a89e8a665d04d7b5460d39ef7df53 > commons/src/main/java/org/apache/aurora/common/zookeeper/CompoundServerSet.java 42732db6d012d481d2f34882ceec30d3ab8b2d92 > commons/src/main/java/org/apache/aurora/common/zookeeper/DistributedLock.java 1e8fc48c561d64de3f454808b019c10b1f22b3bf > commons/src/main/java/org/apache/aurora/common/zookeeper/DistributedLockImpl.java 99a5774319aedb51f3e8acbab982e7fdfd3cc7d8 > commons/src/main/java/org/apache/aurora/common/zookeeper/Partitioner.java 91ea345cfde96b25a75960666e790decc29ed80f > commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSets.java 2b992684e82d8bc670e19fc9071e9254fa1f9364 > commons/src/main/java/org/apache/aurora/common/zookeeper/StaticServerSet.java 99c290e3cf9131a6cb185de193843d3fd74743b0 > commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperMap.java 29db55a4fae8ab4aabd03fb2a3ed966b64afea81 > commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperNode.java 3829ca7d95345798188fa53129608816a4082a65 > commons/src/main/resources/org/apache/aurora/common/application/http/graphview/dygraph-combined.js dcdd498ba32acd95fc31c271912cbf3ec72f926f > commons/src/main/resources/org/apache/aurora/common/application/http/graphview/dygraph-extra.js 3a353a57c29fc368b5436e32dddd8dab8c8b152a > commons/src/main/resources/org/apache/aurora/common/application/http/graphview/grapher.js 247e6d97bd9f46ce0fc738e679da29c7f21989b8 > commons/src/main/resources/org/apache/aurora/common/application/http/graphview/graphview.html dd3fd5d227b4f5275412fd7f801dd7e013f068e5 > commons/src/main/resources/org/apache/aurora/common/application/http/graphview/parser.js 17acf8413903ae98b8d9737af06d05ad27ce74cb > commons/src/main/resources/org/apache/aurora/common/common/webassets/bootstrap/2.1.1/css/bootstrap-responsive.min.css c39fd97e97f26a0d0a1d89f95aa54e1f3f8acfda > commons/src/main/resources/org/apache/aurora/common/common/webassets/bootstrap/2.1.1/css/bootstrap.min.css cf027829ec58c90d0ad147159bc9ecb33b888457 > commons/src/main/resources/org/apache/aurora/common/common/webassets/bootstrap/2.1.1/img/glyphicons-halflings-white.png 3bf6484a29d8da269f9bc874b25493a45fae3bae > commons/src/main/resources/org/apache/aurora/common/common/webassets/bootstrap/2.1.1/img/glyphicons-halflings.png a9969993201f9cee63cf9f49217646347297b643 > commons/src/main/resources/org/apache/aurora/common/common/webassets/bootstrap/2.1.1/js/bootstrap.min.js 5841dbf31f665401880dd91b83a09f150fb2d444 > commons/src/main/resources/org/apache/aurora/common/common/webassets/bootstrap/2.3.2/css/bootstrap-responsive.min.css 962ec7b3d960fef270a25ec4c32ba212b03e1a56 > commons/src/main/resources/org/apache/aurora/common/common/webassets/bootstrap/2.3.2/css/bootstrap.min.css e09dac802a3fa824fdd4282a76c9db9fc24b684f > commons/src/main/resources/org/apache/aurora/common/common/webassets/bootstrap/2.3.2/img/glyphicons-halflings-white.png 3bf6484a29d8da269f9bc874b25493a45fae3bae > commons/src/main/resources/org/apache/aurora/common/common/webassets/bootstrap/2.3.2/img/glyphicons-halflings.png a9969993201f9cee63cf9f49217646347297b643 > commons/src/main/resources/org/apache/aurora/common/common/webassets/bootstrap/2.3.2/js/bootstrap.min.js 736662d6abaac46ba0df0d5d950058cbecfe88b0 > commons/src/main/resources/org/apache/aurora/common/common/webassets/jquery/js/jquery-1.8.2.min.js 9b43f61804142d69f6936311547045e1a345b265 > commons/src/test/java/org/apache/aurora/common/application/modules/LifecycleModuleTest.java d43a6db128b7813a916bbdf1aab2af3e431f6c9e > commons/src/test/java/org/apache/aurora/common/base/CachingSupplierTest.java 26eb84dde83ba825f157a4a9e1a4481653b04037 > commons/src/test/java/org/apache/aurora/common/base/EitherTest.java 39cb79ec9b62a3079ef22b4f30b06a1f5405f12e > commons/src/test/java/org/apache/aurora/common/base/ExceptionTransporterTest.java b59f658fc9f3b876230126a41b07eefc773c9370 > commons/src/test/java/org/apache/aurora/common/base/ExceptionalFunctionsTest.java 34e0ca6068f5d1b4da55f9e9b306651ef1721f00 > commons/src/test/java/org/apache/aurora/common/collections/BitsTest.java b1c37584d8f036f762f3488f188d0f28d9ceed2e > commons/src/test/java/org/apache/aurora/common/inject/DefaultProviderTest.java 7fd74c93af05d345b7d69f56a5f7d4af0c1ade8f > commons/src/test/java/org/apache/aurora/common/io/Base64ZlibCodecTest.java 0530ca23ebbcd7682eeff6686c43c383ad17dde0 > commons/src/test/java/org/apache/aurora/common/io/JsonCodecTest.java 949e78b0ad4625ad7fa688b60bd95284d144ce49 > commons/src/test/java/org/apache/aurora/common/logging/BufferedLogTest.java b90fbd189110c5d62cdcebca55b8b05a03da52ec > commons/src/test/java/org/apache/aurora/common/logging/LogUtilTest.java 6e6c3b10c3a2ec600119d2d650c5b7ff5d41810b > commons/src/test/java/org/apache/aurora/common/logging/julbridge/JULBridgeHandlerTest.java aef4c8066194453817f7f5e77cef93f5d73f31bc > commons/src/test/java/org/apache/aurora/common/logging/julbridge/JULBridgeLevelConverterTest.java 79dfb260e51edfd6764b6e92435369b166ac7aa3 > commons/src/test/java/org/apache/aurora/common/logging/julbridge/JULBridgeLogManagerTest.java 40eac591a5f9dc63b7acb6126e827cf67b4cb902 > commons/src/test/java/org/apache/aurora/common/net/UrlHelperTest.java c6e84bd8eb405cae6824483cf0f6e40df197c140 > commons/src/test/java/org/apache/aurora/common/net/UrlResolverTest.java eb066fc40013fca5ef8784d6f97127ff16b5c04d > commons/src/test/java/org/apache/aurora/common/net/UrlResolverUtilTest.java 3633da86b2e372fb262916d3914bdf3e7e9f4bc4 > commons/src/test/java/org/apache/aurora/common/net/UrlTokenizerUtilTest.java 6cc8abf05908f576d4555d4947fbc867ab091f72 > commons/src/test/java/org/apache/aurora/common/net/http/RequestLoggerTest.java 3f2309b36f1138a825f3bd913a001bbb460cf7fe > commons/src/test/java/org/apache/aurora/common/net/http/filters/HttpStatsFilterIntegrationTest.java 92ab63b36373be2ce1013684b376608923b24cf9 > commons/src/test/java/org/apache/aurora/common/net/http/filters/HttpStatsFilterTest.java b40964d71e658577defe162f950408fc303da17b > commons/src/test/java/org/apache/aurora/common/net/loadbalancing/LeastConnectedStrategyTest.java dca92bee11f7b6a64b39e6558ca466fe171ea58a > commons/src/test/java/org/apache/aurora/common/net/loadbalancing/LoadBalancerImplTest.java 973bf6bf2d5031fc708d08d690324fdcc7ab2196 > commons/src/test/java/org/apache/aurora/common/net/loadbalancing/MarkDeadStrategyTest.java 4839e172c47d65bbcb8a12aa1e60b518db59774e > commons/src/test/java/org/apache/aurora/common/net/loadbalancing/MarkDeadStrategyWithHostCheckTest.java b3c14ea517fedd22ed0171965519215463f799cd > commons/src/test/java/org/apache/aurora/common/net/loadbalancing/RandomStrategyTest.java 213b0bb8736bb8f4c19ae0444c8a715286c06bf8 > commons/src/test/java/org/apache/aurora/common/net/loadbalancing/RoundRobinStrategyTest.java f07b2a1eed7dbc349b3c6e09943b0c1f091612db > commons/src/test/java/org/apache/aurora/common/net/loadbalancing/SubsetStrategyTest.java 25c228aae586c7e49da4eaf1dfcba1dae2437cf4 > commons/src/test/java/org/apache/aurora/common/net/monitoring/TrafficMonitorTest.java 0593b264d0b9081dc6beb0525d63d50437723062 > commons/src/test/java/org/apache/aurora/common/net/pool/ConnectionPoolTest.java c9f2c48fdd717a95586d40a5ad596e8601009f04 > commons/src/test/java/org/apache/aurora/common/net/pool/DynamicHostSetUtilTest.java b5444993d15b614f229bf1e116e86b95804bea22 > commons/src/test/java/org/apache/aurora/common/net/pool/DynamicPoolTest.java 98324b309dd5c2f73d298480c4c10286f514dc68 > commons/src/test/java/org/apache/aurora/common/objectsize/ObjectSizeCalculatorTest.java b91284488f2716f95da4cf2ee93767dc9cc9e4e0 > commons/src/test/java/org/apache/aurora/common/stats/ApproximateHistogramTest.java 62b8846e3e540135ca37d1d54d00b4615d2c3b0d > commons/src/test/java/org/apache/aurora/common/stats/ElapsedTest.java 3343f4f3330f59142030f7f0beb17769c45aa02a > commons/src/test/java/org/apache/aurora/common/stats/EntropyTest.java 0807986094b548fd7672950e94b6fbb2a047c7b3 > commons/src/test/java/org/apache/aurora/common/stats/MergedHistogramTest.java e71a34f9553053c5961bacbb4cbf13ad36595759 > commons/src/test/java/org/apache/aurora/common/stats/MovingAverageTest.java cce2f69549faee083d2bba8c9378883bb511ed9e > commons/src/test/java/org/apache/aurora/common/stats/MovingWindowDeltaTest.java 857916c090e0346f39827baa2d1e5c7d279b7ebf > commons/src/test/java/org/apache/aurora/common/stats/NumericStatExporterTest.java 23a767d478a0d98afac636550daf48af2268244d > commons/src/test/java/org/apache/aurora/common/stats/PipelineStatsTest.java b090c64d8f393276552bb1a3c75cf16a2c003a0b > commons/src/test/java/org/apache/aurora/common/stats/PrintableHistogramTest.java d2aa019d08b379245097ec2fc58581dfa4d08f17 > commons/src/test/java/org/apache/aurora/common/stats/ReservoirSamplerTest.java 4d5a7e9aeea3ecfde544370948207c92abbf6013 > commons/src/test/java/org/apache/aurora/common/stats/StatisticsTest.java 35c076b2d3544e8730086b62b43264eaa22fdf08 > commons/src/test/java/org/apache/aurora/common/stats/WindowedHistogramTest.java c93801ad411dd93ebb1f903e8b21778ba7baadf8 > commons/src/test/java/org/apache/aurora/common/stats/WindowedStatsTest.java c1431740e689a4d0cf819d8f841dd48fbb19b1f1 > commons/src/test/java/org/apache/aurora/common/stats/WindowedTest.java d0f46dd2cadc08ed1d323bd1fba22233c0616cb9 > commons/src/test/java/org/apache/aurora/common/testing/TearDownRegistryTest.java a9157ec1318845f72afbcd4ca7b8845a7bef1dfb > commons/src/test/java/org/apache/aurora/common/thrift/ThriftConnectionFactoryTest.java 7876264b5c22cce7bbd9345f05aee9de6f781568 > commons/src/test/java/org/apache/aurora/common/thrift/ThriftFactoryTest.java 802caa20d93316c9ec5cdcf5ce8c43fcaa50eda8 > commons/src/test/java/org/apache/aurora/common/thrift/ThriftTest.java 4b96308ff9f9f3b2317c4f0c0e85200dafbd4c0f > commons/src/test/java/org/apache/aurora/common/thrift/callers/AbstractCallerTest.java e66a9daab73ffb050164652247f173e6254181e8 > commons/src/test/java/org/apache/aurora/common/thrift/callers/DeadlineCallerTest.java 6441bd0843ef2ec894bb0706036c7ed9fdebba30 > commons/src/test/java/org/apache/aurora/common/thrift/callers/RetryingCallerTest.java afe4dc9c9a772ec8ce7ba4a9e0858dc3d4f8bf34 > commons/src/test/java/org/apache/aurora/common/util/LowResClockTest.java f564235a863f7c1d4abc103ff0b8e3b28e05b15c > commons/src/test/java/org/apache/aurora/common/util/QueueDrainerTest.java 66082b894050f1b88a7f0b9ae4d5c6fdd498e661 > commons/src/test/java/org/apache/aurora/common/util/RateLimitedCommandExecutorTest.java 245e07d0c25ee8c1fbdb0dd5db01b4cecec21c85 > commons/src/test/java/org/apache/aurora/common/util/caching/CachingMethodProxyTest.java 4c3b248324c62e0a0635434d399305be54316a1d > commons/src/test/java/org/apache/aurora/common/util/caching/LRUCacheTest.java e1a51d27d4defd958be15a6348567355e71af36f > commons/src/test/java/org/apache/aurora/common/zookeeper/CompoundServerSetTest.java a06a814763d98045228d40c13fdd921092955be6 > commons/src/test/java/org/apache/aurora/common/zookeeper/DistributedLockTest.java 00a6648dee3b28b418eec1570a65f8a841ec417c > commons/src/test/java/org/apache/aurora/common/zookeeper/PartitionerTest.java fbc2cdbf6cede618540fe4d5b172ece22bf2e378 > commons/src/test/java/org/apache/aurora/common/zookeeper/ServerSetImplTest.java 1dec34e44d0888e2b6f9faf07f17e87ae1b60f5b > commons/src/test/java/org/apache/aurora/common/zookeeper/StaticServerSetTest.java 9c98951f36e7e59d11d464a78aee4b3b827270ae > commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperMapTest.java 993ab64ff8f8ea1abbebecb85eafcaa08241dbf8 > commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperNodeTest.java fd1bb2279745b43437359b79fb340326ab6f8cf2 > > Diff: https://reviews.apache.org/r/37872/diff/ > > > Testing > ------- > > > Thanks, > > Bill Farner > > --===============1542252990354713404==--