Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 60AFA17BA9 for ; Thu, 27 Aug 2015 23:03:26 +0000 (UTC) Received: (qmail 94648 invoked by uid 500); 27 Aug 2015 23:03:26 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 94595 invoked by uid 500); 27 Aug 2015 23:03:26 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 94559 invoked by uid 99); 27 Aug 2015 23:03:26 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Aug 2015 23:03:26 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 0D24C26C6E2; Thu, 27 Aug 2015 23:03:25 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6038273798032214181==" MIME-Version: 1.0 Subject: Re: Review Request 37860: Rpm: fix install dep on daemonize, be permissive with newer mesos versions. From: "Bill Farner" To: "Kevin Sweeney" Cc: "Bill Farner" , "Aurora" Date: Thu, 27 Aug 2015 23:03:25 -0000 Message-ID: <20150827230325.13584.98036@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Bill Farner" X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/37860/ X-Sender: "Bill Farner" References: <20150827225553.13584.10416@reviews.apache.org> In-Reply-To: <20150827225553.13584.10416@reviews.apache.org> Reply-To: "Bill Farner" X-ReviewRequest-Repository: aurora-packaging --===============6038273798032214181== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Aug. 27, 2015, 3:55 p.m., Kevin Sweeney wrote: > > specs/rpm/aurora.spec, line 100 > > > > > > Can you explain the rationale behind this change - unpinned mesos runs the risk of not working with the executor it was compiled against. Much as we might wish that this will work, we don't know that it will and it's much easier to debug an error from yum than a runtime linker issue. If a user is convinced that we're wrong here they can always override with `--nodeps`. Sure, i'll abandon. Perhaps the right approach will be for us to do point releases to pick up new mesos versions. - Bill ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37860/#review96782 ----------------------------------------------------------- On Aug. 27, 2015, 3:50 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37860/ > ----------------------------------------------------------- > > (Updated Aug. 27, 2015, 3:50 p.m.) > > > Review request for Aurora and Kevin Sweeney. > > > Repository: aurora-packaging > > > Description > ------- > > Rpm: fix install dep on daemonize, be permissive with newer mesos versions. > > > Diffs > ----- > > specs/rpm/aurora.spec 3e7b8bef2272d935f3efb3e3ea6e4ac510026b7d > > Diff: https://reviews.apache.org/r/37860/diff/ > > > Testing > ------- > > Successfully ran what jenkins runs: > ``` > ./build-artifact.sh builder/rpm/centos-7 ~/snapshot.tar.gz 0.10.0snapshot.2015.08.27 > ``` > > > Thanks, > > Bill Farner > > --===============6038273798032214181==--